diff options
| author | Noe Rubinstein <nrubinstein@proformatique.com> | 2010-10-29 16:41:32 +0200 |
|---|---|---|
| committer | Noe Rubinstein <nrubinstein@proformatique.com> | 2010-10-29 16:41:32 +0200 |
| commit | 4af0ad04002b7e02226975bf1af73ea00e077f74 (patch) | |
| tree | 98a3a8c04f8763886360c6b6c30585d611b47036 /xhfc | |
| parent | 695c96449a1efce4036cc981f21dc545ff680d17 (diff) | |
todo/comments
Diffstat (limited to 'xhfc')
| -rw-r--r-- | xhfc/TODO | 11 | ||||
| -rw-r--r-- | xhfc/xhfc.c | 4 |
2 files changed, 7 insertions, 8 deletions
@@ -1,9 +1,8 @@ -- the code is a bloody mess, clean it up - - XXX & TODO - - remove any commented-out code -- the B chan and PCM stuff is not implemented at all - shouldn't part of what is done in the interrupt handler be done later in a tasklet? -- keep in mind that there is no sync. I think it's not a problem, but in case - a tasklet is used it could become one. +- Sync warning: prolly no problem currently, but linked to our architecture + + context (hardirq vs. softirq) (running etc.) +- Rewrite the S/T state handling code. +- Review again the FIFO rw code (WTF comments) +- (Low priority) check support for other XHFCs diff --git a/xhfc/xhfc.c b/xhfc/xhfc.c index 7bf7d4d..fcf9488 100644 --- a/xhfc/xhfc.c +++ b/xhfc/xhfc.c @@ -448,8 +448,8 @@ static uint frames_out; /* * Takes one blob of data from DAHDI and shoots it out to the hardware. The * blob may or may not be a complete HDLC frame. If it isn't, the D-channel -* FIFO interrupt handler will take care of pulling the rest. Returns nonzero -* if there is still data to send in the current HDLC frame. +* FIFO interrupt handler will take care of pulling the rest. //XXX FOUTAISES!!! +* Returns nonzero if there is still data to send in the current HDLC frame. */ static int hdlc_tx_frame(struct xhfc_span *xhfc_span) { |