diff options
| author | Guillaume Knispel <gknispel@proformatique.com> | 2010-10-11 19:29:21 +0200 |
|---|---|---|
| committer | Guillaume Knispel <gknispel@proformatique.com> | 2010-10-11 19:29:21 +0200 |
| commit | 131aad6ae9a6eaed89e6c969481e23c75976cf95 (patch) | |
| tree | 023aa35e40bcde562dfa6fa116b80db3fc4adcc2 /xhfc | |
| parent | c53022585170110b80ed745fccd061e9c7ec2a70 (diff) | |
comments
Diffstat (limited to 'xhfc')
| -rw-r--r-- | xhfc/xhfc.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/xhfc/xhfc.c b/xhfc/xhfc.c index 90dddfb..4e6ea63 100644 --- a/xhfc/xhfc.c +++ b/xhfc/xhfc.c @@ -215,12 +215,12 @@ void xhfc_config_d_chan_on_fifo(struct xhfc *x, int fifo, int direction) SET_V_HDLC_TRP(a_con_hdlc, 0); /* HDLC mode */ SET_V_FIFO_IRQ(a_con_hdlc, 7); /* FIFO & IRQ enabled */ SET_V_CH_FNUM(a_channel, fifo); /* chan number */ - SET_V_BIT_CNT(a_subch_cfg, 2); /* only two bytes read or written */ + SET_V_BIT_CNT(a_subch_cfg, 2); /* only two bits read or written */ SET_V_RES_FIFO(a_inc_res_fifo, 1); /* reset FIFO */ SET_V_RES_LOST(a_inc_res_fifo, 1); /* reset FIFO */ SET_V_RES_FIFO_ERR(a_inc_res_fifo, 1); /* reset FIFO */ - SET_V_DATA_FLOW(a_con_hdlc, 0); /* FIFO -> ST/Up */ + SET_V_DATA_FLOW(a_con_hdlc, 0); /* FIFO <-> ST/Up */ SET_V_FIFO_DIR(r_fifo, direction); SET_V_CH_FDIR(a_channel, direction); @@ -241,12 +241,14 @@ void xhfc_config_b_chan_on_fifo(struct xhfc *x, int fifo, int slot, int directio SET_V_FIFO_DIR(r_fifo, direction); SET_V_FIFO_NUM(r_fifo, fifo); - SET_V_REV(r_fifo, 0); + SET_V_REV(r_fifo, 0); /* XXX should not this be 1 for transp mode? */ + /* if the fifo is not really used, maybe it's */ + /* "don't care" */ - SET_V_IFF(a_con_hdlc, 0); /* Ox7E as interframe fill */ + SET_V_IFF(a_con_hdlc, 0); /* Ox7E as interframe fill -- not really used */ SET_V_HDLC_TRP(a_con_hdlc, 1); /* transparent mode */ SET_V_FIFO_IRQ(a_con_hdlc, 7); /* enable data transmission */ - SET_V_DATA_FLOW(a_con_hdlc, 6); /* '110': ST -> PCM */ + SET_V_DATA_FLOW(a_con_hdlc, 6); /* '110': ST <-> PCM */ SET_V_SL_DIR(r_slot, direction); SET_V_SL_NUM(r_slot, slot); |