diff options
| author | Christian Brauner <brauner@kernel.org> | 2024-11-25 15:10:06 +0100 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-12-02 11:25:10 +0100 |
| commit | b37eab47cf5479f974c029e23d84f9049d4df009 (patch) | |
| tree | 4a0beeb52c98bb90b47399270b30b214cf988e0e | |
| parent | 7c0c3b346adafb515a5ff085c68c92695c4fdb04 (diff) | |
aio: avoid pointless cred reference count bump
iocb->fsync.creds already holds a reference count that is stable while
the operation is performed.
Link: https://lore.kernel.org/r/20241125-work-cred-v2-10-68b9d38bb5b2@kernel.org
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Christian Brauner <brauner@kernel.org>
| -rw-r--r-- | fs/aio.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/aio.c b/fs/aio.c index 5e57dcaed7f1a..50671640b5883 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -1639,10 +1639,10 @@ static int aio_write(struct kiocb *req, const struct iocb *iocb, static void aio_fsync_work(struct work_struct *work) { struct aio_kiocb *iocb = container_of(work, struct aio_kiocb, fsync.work); - const struct cred *old_cred = override_creds(get_new_cred(iocb->fsync.creds)); + const struct cred *old_cred = override_creds(iocb->fsync.creds); iocb->ki_res.res = vfs_fsync(iocb->fsync.file, iocb->fsync.datasync); - put_cred(revert_creds(old_cred)); + revert_creds(old_cred); put_cred(iocb->fsync.creds); iocb_put(iocb); } |