summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Brauner <brauner@kernel.org>2024-11-25 15:10:05 +0100
committerChristian Brauner <brauner@kernel.org>2024-12-02 11:25:10 +0100
commit7c0c3b346adafb515a5ff085c68c92695c4fdb04 (patch)
tree600001eb82ef000f452bd358a01b7549ab730bd2
parent25fe3d58e4ba20b1ec98d7ce9067ddd234e8e448 (diff)
target_core_configfs: avoid pointless cred reference count bump
The creds are allocated via prepare_kernel_cred() which has already taken a reference. Link: https://lore.kernel.org/r/20241125-work-cred-v2-9-68b9d38bb5b2@kernel.org Reviewed-by: Jeff Layton <jlayton@kernel.org> Reviewed-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Christian Brauner <brauner@kernel.org>
-rw-r--r--drivers/target/target_core_configfs.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index ec7a55987193..c40217f44b1b 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -3756,9 +3756,9 @@ static int __init target_core_init_configfs(void)
ret = -ENOMEM;
goto out;
}
- old_cred = override_creds(get_new_cred(kern_cred));
+ old_cred = override_creds(kern_cred);
target_init_dbroot();
- put_cred(revert_creds(old_cred));
+ revert_creds(old_cred);
put_cred(kern_cred);
return 0;