diff options
| author | Flavio Cruz <flaviocruz@gmail.com> | 2015-12-31 16:45:51 +0100 |
|---|---|---|
| committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2015-12-31 16:48:11 +0100 |
| commit | 8058ef787e82504d0b6fab9384f1b74f72393f1a (patch) | |
| tree | 833b0d32d5a456b99efcfa4511fb7f97d1df5960 /term | |
| parent | f2524f5bfed878ae229eea3484dad2e0e9369b3a (diff) | |
Use DEVICE_IMPORTS to include libports/ports.h
On Thu, Dec 31, 2015 at 04:28:14PM +0100, Justus Winter wrote:
> Quoting Samuel Thibault (2015-12-31 16:11:30)
> > Flavio Cruz, on Thu 31 Dec 2015 15:56:31 +0100, wrote:
> > > This fixes three compiler warnings about ports_payload_get_name.
> > >
> > > * devnode/Makefile: Define DEVICE_IMPORTS.
> > > * term/Makefile: Likewise.
> > > * trans/Makefile: Likewise.
> >
> > Why not adding them to the corresponding mig-mutate.h?
>
> Sometimes we don't have a mig-mutate.h, e.g. for most (all?)
> translators in trans/. I prefer stuffing that in a .h as well, but I
> wouldn't be opposed to just applying the patch, as we use both ways of
> mutating the mig types.
Agreed. I think only devnode should include it in mig-mutate.h. For
term, only some stubs are including mig-mutate.h. For trans, there's no
mig-mutate.h at all. Here's the modified patch.
Diffstat (limited to 'term')
| -rw-r--r-- | term/Makefile | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/term/Makefile b/term/Makefile index 1419d2a3..78766041 100644 --- a/term/Makefile +++ b/term/Makefile @@ -33,6 +33,8 @@ include ../Makeconf device_replyServer-CPPFLAGS = -DTypeCheck=0 -Wno-unused # XXX -device_reply-MIGSFLAGS = -DMACH_PAYLOAD_TO_PORT=ports_payload_get_name +device_reply-MIGSFLAGS=\ + "-DMACH_PAYLOAD_TO_PORT=ports_payload_get_name" \ + "-DDEVICE_IMPORTS=import \"$(srcdir)/../libports/ports.h\";" tioctl-MIGSFLAGS = -imacros $(srcdir)/mig-mutate.h term-MIGSFLAGS = -imacros $(srcdir)/mig-mutate.h |