summaryrefslogtreecommitdiff
path: root/drivers/staging/slicoss
AgeCommit message (Collapse)Author
2009-12-11Staging: slicoss: remove duplicate structure field initializationJulia Lawall
The definition of slic_netdev_ops has initializations of a local function and eth_mac_addr for its ndo_set_mac_address field. This change uses only the local function. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ identifier I, s, fld; position p0,p; expression E; @@ struct I s =@p0 { ... .fld@p = E, ...}; @s@ identifier I, s, r.fld; position r.p0,p; expression E; @@ struct I s =@p0 { ... .fld@p = E, ...}; @script:python@ p0 << r.p0; fld << r.fld; ps << s.p; pr << r.p; @@ if int(ps[0].line)!=int(pr[0].line) or int(ps[0].column)!=int(pr[0].column): cocci.print_main(fld,p0) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-09-15Staging: ARRAY_SIZE changesStoyan Gaydarov
These changes were a direct result of using a semantic patch More information can be found at http://www.emn.fr/x-info/coccinelle/ Signed-off-by: Stoyan Gaydarov <sgayda2@uiuc.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-07-05net: use NETDEV_TX_OK instead of 0 in ndo_start_xmit() functionsPatrick McHardy
This patch is the result of an automatic spatch transformation to convert all ndo_start_xmit() return values of 0 to NETDEV_TX_OK. Some occurences are missed by the automatic conversion, those will be handled in a seperate patch. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
2009-06-19Staging: slicoss: fix build warningsGreg Kroah-Hartman
This fixes some build warnings in the slicoss driver. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-06-19Staging: slicoss: Add missing __devexit_p()Jean Delvare
The remove function uses __devexit, so the .remove assignment needs __devexit_p() to fix a build error with hotplug disabled. Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-17staging: slicoss: update READMEStephen Hemminger
I looked, I gagged, I left Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-17Revert Staging: SLICOSS: use gfp_kernel where possibleLior Dotan
Revert commit 2bb347361e2c19799431f56488a3f64de40a3aa6 This commit has been reported to cause problems: Mar 24 11:50:31 linuxdev kernel: BUG: sleeping function called from invalid context at mm/slub.c:1599 Mar 24 11:50:31 linuxdev kernel: in_atomic(): 1, irqs_disabled(): 0, pid: 3251, name: avahi-daemon Cc: Lior Dotan <liodot@gmail.com> Cc: Christopher Harrer <charrer@alacritech.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-17Staging: slicoss: convert to netdev_opsAlexander Beregalov
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com> Acked-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-07dma-mapping: replace all DMA_64BIT_MASK macro with DMA_BIT_MASK(64)Yang Hongyang
Replace all DMA_64BIT_MASK macro with DMA_BIT_MASK(64) Signed-off-by: Yang Hongyang<yanghy@cn.fujitsu.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-04-03Staging: slicoss: slichw.h cleanupGreg Kroah-Hartman
Lots of spaces->tabs cleanups for slichw.h It's much more sane and "Linux-like" now. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: delete slicdbg.hGreg Kroah-Hartman
Move the ASSERT macro into slicoss.c as that's all that is currently being used. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove ASSERTMSG macroGreg Kroah-Hartman
No one uses it, so drop it. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove DBG_ERROR macroGreg Kroah-Hartman
Use the dev_err() call instead, it is the standard and provides much more information. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove SLICLEVEL and SLIC_DISPLAY macrosGreg Kroah-Hartman
They aren't needed or used anymore. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove SLIC_ETHTOOL_SUPPORTGreg Kroah-Hartman
It was always enabled, so just always use it. Cleaned up the ioctl code a bit as well to make it more readable. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove DBG_MSGGreg Kroah-Hartman
It's not being used for anything, so delete it and all instances of it. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove VALID_ADDRESS macroGreg Kroah-Hartman
It's quite wierd, and doesn't even do anything on x86_64, so just delete it. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove SLIC_PING_TIMER_ENABLEDGreg Kroah-Hartman
It was always enabled, so just enable it properly. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove LINUX_FREES_ADAPTER_RESOURCESGreg Kroah-Hartman
It was always enabled, so just enable it and take out the one place it was being used. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove SLIC_POWER_MANAGEMENT_ENABLEDGreg Kroah-Hartman
It was always disabled, so just remove it and the 2 lines of code it was protecting. Also remove SLIC_POWER_MANAGEMENT which was also disabled, yet was never used. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: add proper KERN_DEBUG to 2 printksGreg Kroah-Hartman
Added bonus is this fixes a compiler warning on 4.3.3 Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove SLIC_GET_STATS_ENABLEDGreg Kroah-Hartman
It was always enabled, so just turn on the code that was being always enabled, and remove the #define. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: delete slicinc.hGreg Kroah-Hartman
Putting static function prototypes in a .h file doesn't make much sense. Move the ones that we need into the .c file and delete the rest. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove SLIC_GET_STATS_TIMER_ENABLEDGreg Kroah-Hartman
SLIC_GET_STATS_TIMER_ENABLED was never defined, so remove the code that was bound by it. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: clean up SLIC_DUMP_ENABLEDGreg Kroah-Hartman
As SLIC_DUMP_ENABLED was disabled, remove the code that it was keeping from being built as it was not ever used. This removed a lot. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: delete slicbuild.hGreg Kroah-Hartman
It was just duplicating the same #defines already in the .c file and it wasn't even being #included in any file. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove unused #definesGreg Kroah-Hartman
There are a number of "config" defines that do nothing, remove them. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove slic_os.hGreg Kroah-Hartman
It's no longer needed, and empty, so remove it. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove WRITE_REG wrapperGreg Kroah-Hartman
It's not needed, so just call the function instead of using a define. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove WRITE_REG64 wrapperGreg Kroah-Hartman
It's not needed, so just call the function instead of using a define. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove DEBUG_REGISTER_TRACEGreg Kroah-Hartman
It's not ever defined, so remove it from the code base. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove jiffies macrosGreg Kroah-Hartman
Use the ones built into the kernel, don't reinvent the wheel. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: remove TRUE/FALSE usageGreg Kroah-Hartman
Don't use TRUE and FALSE, we have proper boolean types in the kernel. Cc: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: SLICOSS: use gfp_kernel where possibleLior Dotan
Use GFP_KERNEL instead of GFP_ATOMIC where possible. Signed_off-by: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: SLICOSS: free resources on entry_probe error pathLior Dotan
Call pci_disable_device() and free_netdev() if slic_entry_probe fails. Signed_off-by: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: add binary firmware to firmware directoryLior Dotan
Adds the firmware to the firmware directory in ihex format so it can be installed when doing make firmware_install. Also update the firmware location in the driver code so it can locate the files in the right place. This should conclude the move to request_firmware(). Signed-off-by: Lior Dotan <liodot@gmail.com> Cc: Christopher Harrer <charrer@alacritech.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: SLICOSS: remove the static firmware header filesLior Dotan
Remove the static headers with the firmware code, they are no longer needed. Signed-off-by: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-04-03Staging: slicoss: use request_firmwareLior Dotan
This patch uses request_firmware() to download the firmware to the card. Signed-off-by: Lior Dotan <liodot@gmail.com> Cc: Christopher Harrer <charrer@alacritech.com>
2009-01-06Staging: slicoss: use request_firmwareLior Dotan
This should make the driver use request_firmware() instead of a static firmware. Some obvious things are missing: 1) The unneeded header files are not removed yet. This is to keep the patch size small. 2) The .bin files are missing so the driver doesn't have what to load. 3) Testing. None of this was tested. It does compiles OK though :) Signed-off-by: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-01-06Staging: slicoss: use correct type for memory allcationsLior Dotan
Fix sizeof to use the right type Signed-off-by: Lior Dotan <liodot@gmail.com> Cc: Jiri Slaby <jirislaby@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2009-01-06Staging: slicoss: use kzallocLior Dotan
This patch uses kzalloc() where really applicable. Signed-off-by: Lior Dotan <liodot@gmail.com> Cc: Jiri Slaby <jirislaby@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2008-12-06staging-slicoss: Kill directly reference of netdev->privWang Chen
Simply replace netdev->priv with netdev_priv(). Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com> Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: David S. Miller <davem@davemloft.net>
2008-10-22Staging: SLICOSS: Free multicast list at driver exitLior Dotan
The multicast address list is allocated in slic_mcast_add_list() but never freed. Signed-off-by: Lior Dotan <liodot@gmail.com>
2008-10-22Staging: SLICOSS: remove unused #include <version.h>Huang Weiyi
The file(s) below do not use LINUX_VERSION_CODE nor KERNEL_VERSION. drivers/staging/slicoss/slicoss.c This patch removes the said #include <version.h>. Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2008-10-22Staging: SLICOSS: remove duplicated #include'sHuang Weiyi
Removed duplicated #include's in drivers/staging/slicoss/slicoss.c. linux/delay.h linux/etherdevice.h linux/init.h linux/netdevice.h linux/pci.h linux/skbuff.h linux/slab.h linux/string.h Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2008-10-22staging: fix potential build error in slicoss driverMariusz Kozlowski
This hides under DEBUG_REGISTER_TRACE so probably not visible to many people. Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2008-10-10Staging: SLICOSS: Call pci_release_regions at driver exitLior Dotan
slic_entry_probe() calls pci_request_regions() but there's no matching pci_release_regions() at driver's exit or if slic_entry_probe() fails. Signed-off-by: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2008-10-10Staging: SLICOSS: Fix remaining type namesLior Dotan
Fix the remaining variables that still had '_t' as a postfix and also a couple of checkpatch warnings. Signed-off-by: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2008-10-10Staging: SLICOSS: Fix warnings due to static usageLior Dotan
Fix a few warning messages that crept in due to conversion of all the functions to static Signed-off-by: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2008-10-10Staging: SLICOSS: lots of checkpatch fixesLior Dotan
Major cleanups of checkpatch warnings from the slicoss driver. From: Lior Dotan <liodot@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-23 17:51:25 +0000