diff options
| author | Alexey Dobriyan <adobriyan@gmail.com> | 2010-02-26 17:48:40 +0100 |
|---|---|---|
| committer | Patrick McHardy <kaber@trash.net> | 2010-02-26 17:48:40 +0100 |
| commit | a49c65037146bfb2fe300b8277b10b4479fea5fc (patch) | |
| tree | 3007e26205ca186f3122948efbb402d316253966 /net/netfilter/nfnetlink_log.c | |
| parent | 51f0bc78680edccb6574ef56bd32f9e2939c8a5a (diff) | |
netfilter: nfnetlink_log: fix silly refcount leak
Quick fix for memory/module refcount leak.
Reference count of listener instance never reaches 0.
Start/stop of ulogd2 is enough to trigger this bug!
Now, refcounting there looks very fishy in particular this code:
if (!try_module_get(THIS_MODULE)) {
...
and creation of listener instance with refcount 2,
so it may very well be ripped and redone. :-)
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Diffstat (limited to 'net/netfilter/nfnetlink_log.c')
| -rw-r--r-- | net/netfilter/nfnetlink_log.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c index 285e9029a9f..d9b8fb8ab34 100644 --- a/net/netfilter/nfnetlink_log.c +++ b/net/netfilter/nfnetlink_log.c @@ -768,7 +768,7 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb, } instance_destroy(inst); - goto out; + goto out_put; default: ret = -ENOTSUPP; break; |