summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--arch/x86/machine/cpu.h3
-rw-r--r--arch/x86/machine/strace.h2
-rw-r--r--kern/atomic.h3
-rw-r--r--kern/log2.h2
-rw-r--r--kern/macros.h10
5 files changed, 18 insertions, 2 deletions
diff --git a/arch/x86/machine/cpu.h b/arch/x86/machine/cpu.h
index b9f8c0df..30258460 100644
--- a/arch/x86/machine/cpu.h
+++ b/arch/x86/machine/cpu.h
@@ -24,6 +24,9 @@
* L1 cache line size.
*
* XXX Use this value until processor selection is available.
+ *
+ * TODO Add macros to specifically align to the cache line size, and to
+ * do so only in SMP configurations.
*/
#define CPU_L1_SIZE 64
diff --git a/arch/x86/machine/strace.h b/arch/x86/machine/strace.h
index 2f686a07..b55f6b88 100644
--- a/arch/x86/machine/strace.h
+++ b/arch/x86/machine/strace.h
@@ -16,6 +16,8 @@
*
*
* Stack tracing.
+ *
+ * TODO Make it possible to debug without the frame pointer.
*/
#ifndef _X86_STRACE_H
diff --git a/kern/atomic.h b/kern/atomic.h
index 08e7713e..940720a9 100644
--- a/kern/atomic.h
+++ b/kern/atomic.h
@@ -16,6 +16,9 @@
*
*
* Type-generic memory-model aware atomic operations.
+ *
+ * TODO Replace mentions of "memory barriers" throughout the code with
+ * C11 memory model terminology.
*/
#ifndef _KERN_ATOMIC_H
diff --git a/kern/log2.h b/kern/log2.h
index ed12b441..762aaa77 100644
--- a/kern/log2.h
+++ b/kern/log2.h
@@ -16,6 +16,8 @@
*
*
* Integer base 2 logarithm operations.
+ *
+ * TODO Fix naming.
*/
#ifndef _KERN_LOG2_H
diff --git a/kern/macros.h b/kern/macros.h
index 2c06be51..0411da23 100644
--- a/kern/macros.h
+++ b/kern/macros.h
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2009, 2010, 2013 Richard Braun.
+ * Copyright (c) 2009-2018 Richard Braun.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -19,6 +19,8 @@
*
* This file is a top header in the inclusion hierarchy, and shouldn't include
* other headers that may cause circular dependencies.
+ *
+ * TODO Improve documentation.
*/
#ifndef _KERN_MACROS_H
@@ -28,10 +30,14 @@
#error "GCC 4+ required"
#endif
+#ifndef __ASSEMBLER__
+#include <stddef.h>
+#endif
+
/*
* Attributes for variables that are mostly read and seldom changed.
*/
-#define __read_mostly __section(".data.read_mostly")
+#define __read_mostly __section(".data.read_mostly")
#define MACRO_BEGIN ({
#define MACRO_END })