linux/linux-stable.git - Linux kernel stable tree

Age	Commit message (Collapse)	Author
2024-02-15	scsi: csiostor: Avoid function pointer casts	Arnd Bergmann
	csiostor uses function pointer casts to keep the csio_ln_ev state machine hidden, but this causes warnings about control flow integrity (KCFI) violations in clang-16 and higher: drivers/scsi/csiostor/csio_lnode.c:1098:33: error: cast from 'void ()(struct csio_lnode , enum csio_ln_ev)' to 'csio_sm_state_t' (aka 'void ()(void , unsigned int)') converts to incompatible function type [-Werror,-Wcast-function-type-strict] 1098 \| return (csio_get_state(ln) == ((csio_sm_state_t)csio_lns_ready)); \| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/csiostor/csio_lnode.c:1369:29: error: cast from 'void ()(struct csio_lnode , enum csio_ln_ev)' to 'csio_sm_state_t' (aka 'void ()(void , unsigned int)') converts to incompatible function type [-Werror,-Wcast-function-type-strict] 1369 \| if (csio_get_state(ln) == ((csio_sm_state_t)csio_lns_uninit)) { \| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/csiostor/csio_lnode.c:1373:29: error: cast from 'void ()(struct csio_lnode , enum csio_ln_ev)' to 'csio_sm_state_t' (aka 'void ()(void , unsigned int)') converts to incompatible function type [-Werror,-Wcast-function-type-strict] 1373 \| if (csio_get_state(ln) == ((csio_sm_state_t)csio_lns_ready)) { \| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/scsi/csiostor/csio_lnode.c:1377:29: error: cast from 'void ()(struct csio_lnode , enum csio_ln_ev)' to 'csio_sm_state_t' (aka 'void ()(void , unsigned int)') converts to incompatible function type [-Werror,-Wcast-function-type-strict] 1377 \| if (csio_get_state(ln) == ((csio_sm_state_t)csio_lns_offline)) { \| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Move the enum into a shared header so the correct types can be used without the need for casts. Fixes: a3667aaed569 ("[SCSI] csiostor: Chelsio FCoE offload driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/r/20240213100518.457623-1-arnd@kernel.org Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2013-05-02	[SCSI] csiostor: off by one error	Dan Carpenter
	We need to store PROTO_ERR_IMPL_LOGO (26) things here, but the first element isn't used so the array should have 27 elements. This matches fwevt_to_rnevt[] which has 27 elements. The patch solves a Smatch static checker warning on my system: drivers/scsi/csiostor/csio_rnode.c:880 csio_rnode_fwevt_handler() error: buffer overflow '(rn)->stats.n_evt_fw' 26 <= 26 Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Naresh Kumar Inna <naresh@chelsio.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
2013-03-14	csiostor: Header file modifications for chip support and bug fixes.	Arvind Bhushan
	This patch defines the common operations to support multiple chips. It includes common header file modifications to support the current chips (T4 and T5). It also includes the following bug fixes: - reconfirms the rnode state after an implicit logo. - corrects the stats array size. - sets up and checks flags correctly when coming up as master and finding the card initialized Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Arvind Bhushan <arvindb@chelsio.com> Signed-off-by: Naresh Kumar Inna <naresh@chelsio.com> Signed-off-by: David S. Miller <davem@davemloft.net>
2012-11-27	[SCSI] csiostor: Chelsio FCoE offload driver	Naresh Kumar Inna
	Signed-off-by: Naresh Kumar Inna <naresh@chelsio.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>