diff options
author | Peter Seiderer <ps.report@gmx.net> | 2025-02-19 09:45:24 +0100 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2025-02-20 17:24:56 -0800 |
commit | 3ba38c25a8c03b77ed448220a6c93dd5552a264e (patch) | |
tree | 9c6b455b76b56dd4ac1d08c473da978256ecd230 /tools/testing/selftests/net/lib/py/utils.py | |
parent | b38504346a2400c822cc57d0164521405fb12757 (diff) |
net: pktgen: fix 'rate 0' error handling (return -EINVAL)
Given an invalid 'rate' command e.g. 'rate 0' the return value is '1',
leading to the following misleading output:
- the good case
$ echo "rate 100" > /proc/net/pktgen/lo\@0
$ grep "Result:" /proc/net/pktgen/lo\@0
Result: OK: rate=100
- the bad case (before the patch)
$ echo "rate 0" > /proc/net/pktgen/lo\@0"
-bash: echo: write error: Invalid argument
$ grep "Result:" /proc/net/pktgen/lo\@0
Result: No such parameter "ate"
- with patch applied
$ echo "rate 0" > /proc/net/pktgen/lo\@0
-bash: echo: write error: Invalid argument
$ grep "Result:" /proc/net/pktgen/lo\@0
Result: Idle
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250219084527.20488-5-ps.report@gmx.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'tools/testing/selftests/net/lib/py/utils.py')
0 files changed, 0 insertions, 0 deletions