diff options
author | Kuniyuki Iwashima <kuniyu@amazon.com> | 2025-02-27 20:23:27 -0800 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2025-03-03 15:04:11 -0800 |
commit | 254ba7e6032d3fc738050d500b0c1d8197af90ca (patch) | |
tree | 518912427d1d66a2e3ca1588a0a9f6cc5299bc05 /tools/perf/scripts/python/export-to-postgresql.py | |
parent | c0ebe1cdc2cff0dee092a67f2c50377bb5fcf43d (diff) |
ipv4: fib: Move fib_valid_key_len() to rtm_to_fib_config().
fib_valid_key_len() is called in the beginning of fib_table_insert()
or fib_table_delete() to check if the prefix length is valid.
fib_table_insert() and fib_table_delete() are called from 3 paths
- ip_rt_ioctl()
- inet_rtm_newroute() / inet_rtm_delroute()
- fib_magic()
In the first ioctl() path, rtentry_to_fib_config() checks the prefix
length with bad_mask(). Also, fib_magic() always passes the correct
prefix: 32 or ifa->ifa_prefixlen, which is already validated.
Let's move fib_valid_key_len() to the rtnetlink path, rtm_to_fib_config().
While at it, 2 direct returns in rtm_to_fib_config() are changed to
goto to match other places in the same function
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://patch.msgid.link/20250228042328.96624-12-kuniyu@amazon.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions