diff options
| author | Michal Kubiak <michal.kubiak@intel.com> | 2024-09-04 17:47:47 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-10-04 16:33:46 +0200 |
| commit | b249b7b1b13435218b76ccdd02479008acc3d35b (patch) | |
| tree | 1bb1a741f8213782a47d40f3eee3fbbbe3583903 /security/security.c | |
| parent | 710e93ec5c3dafdfe8d384afde5be841d8cd3f1e (diff) | |
idpf: fix netdev Tx queue stop/wake
[ Upstream commit e4b398dd82f5d5867bc5f442c43abc8fba30ed2c ]
netif_txq_maybe_stop() returns -1, 0, or 1, while
idpf_tx_maybe_stop_common() says it returns 0 or -EBUSY. As a result,
there sometimes are Tx queue timeout warnings despite that the queue
is empty or there is at least enough space to restart it.
Make idpf_tx_maybe_stop_common() inline and returning true or false,
handling the return of netif_txq_maybe_stop() properly. Use a correct
goto in idpf_tx_maybe_stop_splitq() to avoid stopping the queue or
incrementing the stops counter twice.
Fixes: 6818c4d5b3c2 ("idpf: add splitq start_xmit")
Fixes: a5ab9ee0df0b ("idpf: add singleq start_xmit and napi poll")
Cc: stable@vger.kernel.org # 6.7+
Signed-off-by: Michal Kubiak <michal.kubiak@intel.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'security/security.c')
0 files changed, 0 insertions, 0 deletions