summaryrefslogtreecommitdiff
path: root/scripts/clang-tools/run-clang-tools.py
diff options
context:
space:
mode:
authorNathan Chancellor <nathan@kernel.org>2023-02-15 10:12:12 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-03-17 08:50:31 +0100
commitb655ba93b51fc8813eead0b4a9b24a666fb18b09 (patch)
tree53d4ce951c388c197de5ce383ec622d327f71ed3 /scripts/clang-tools/run-clang-tools.py
parent69c74104b0e92eeb41186ccc41fc9ed9de923232 (diff)
macintosh: windfarm: Use unsigned type for 1-bit bitfields
[ Upstream commit 748ea32d2dbd813d3bd958117bde5191182f909a ] Clang warns: drivers/macintosh/windfarm_lm75_sensor.c:63:14: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion] lm->inited = 1; ^ ~ drivers/macintosh/windfarm_smu_sensors.c:356:19: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion] pow->fake_volts = 1; ^ ~ drivers/macintosh/windfarm_smu_sensors.c:368:18: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion] pow->quadratic = 1; ^ ~ There is no bug here since no code checks the actual value of these fields, just whether or not they are zero (boolean context), but this can be easily fixed by switching to an unsigned type. Signed-off-by: Nathan Chancellor <nathan@kernel.org> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/20230215-windfarm-wsingle-bit-bitfield-constant-conversion-v1-1-26415072e855@kernel.org Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'scripts/clang-tools/run-clang-tools.py')
0 files changed, 0 insertions, 0 deletions