summaryrefslogtreecommitdiff
path: root/rust
diff options
context:
space:
mode:
authorI Hsin Cheng <richard120310@gmail.com>2025-03-10 15:38:52 +0800
committerMiguel Ojeda <ojeda@kernel.org>2025-05-22 12:00:37 +0200
commit28669b2f37e9b7e98b62d0be2e10a5bf31c2b16f (patch)
tree2712d4f7f37b606850a81f0b9307ccfd7164226f /rust
parent249c3a0e53acefc2b06d3b3e1fc28fb2081f878d (diff)
rust: list: Use "List::is_empty()" to perform checking when possible
"List::is_empty()" provides a straight forward convention to check whether a given "List" is empty or not. There're numerous places in the current implementation still use "self.first.is_null()" to perform the equivalent check, replace them with "List::is_empty()". Signed-off-by: I Hsin Cheng <richard120310@gmail.com> Link: https://lore.kernel.org/r/20250310073853.427954-1-richard120310@gmail.com Reviewed-by: Benno Lossin <lossin@kernel.org> [ Rebased dropping the cases that do not apply anymore. - Miguel ] Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Diffstat (limited to 'rust')
-rw-r--r--rust/kernel/list.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/rust/kernel/list.rs b/rust/kernel/list.rs
index a335c3b1ff5e..7740c8f16cf6 100644
--- a/rust/kernel/list.rs
+++ b/rust/kernel/list.rs
@@ -319,7 +319,7 @@ impl<T: ?Sized + ListItem<ID>, const ID: u64> List<T, ID> {
/// Removes the last item from this list.
pub fn pop_back(&mut self) -> Option<ListArc<T, ID>> {
- if self.first.is_null() {
+ if self.is_empty() {
return None;
}
@@ -331,7 +331,7 @@ impl<T: ?Sized + ListItem<ID>, const ID: u64> List<T, ID> {
/// Removes the first item from this list.
pub fn pop_front(&mut self) -> Option<ListArc<T, ID>> {
- if self.first.is_null() {
+ if self.is_empty() {
return None;
}