diff options
author | Nicholas Bellinger <nab@linux-iscsi.org> | 2015-07-22 00:24:09 -0700 |
---|---|---|
committer | Zefan Li <lizefan@huawei.com> | 2016-03-21 09:17:48 +0800 |
commit | cdaad7c1e1260a7fc83806ce0895a98dab0703a7 (patch) | |
tree | 1afe45ddd5118b3374d28f56bd597f32437b50db /net/unix/af_unix.c | |
parent | db30e3004d3e9f5ade5b531f6df3e5ee5b841b43 (diff) |
iscsi-target: Fix use-after-free during TPG session shutdown
commit 417c20a9bdd1e876384127cf096d8ae8b559066c upstream.
This patch fixes a use-after-free bug in iscsit_release_sessions_for_tpg()
where se_portal_group->session_lock was incorrectly released/re-acquired
while walking the active se_portal_group->tpg_sess_list.
The can result in a NULL pointer dereference when iscsit_close_session()
shutdown happens in the normal path asynchronously to this code, causing
a bogus dereference of an already freed list entry to occur.
To address this bug, walk the session list checking for the same state
as before, but move entries to a local list to avoid dropping the lock
while walking the active list.
As before, signal using iscsi_session->session_restatement=1 for those
list entries to be released locally by iscsit_free_session() code.
Reported-by: Sunilkumar Nadumuttlu <sjn@datera.io>
Cc: Sunilkumar Nadumuttlu <sjn@datera.io>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Zefan Li <lizefan@huawei.com>
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions