diff options
| author | Alexei Potashnik <alexei@purestorage.com> | 2015-07-21 15:07:56 -0700 |
|---|---|---|
| committer | Zefan Li <lizefan@huawei.com> | 2016-03-21 09:17:49 +0800 |
| commit | 874fc85921926885d1984c0cc6e99f569b5a450e (patch) | |
| tree | 4a5bac16d2931f06d447c14af127911ca389f4bd /net/unix/af_unix.c | |
| parent | 3c1a25d2c4dad2a72dfed29513f2931665560050 (diff) | |
target/iscsi: Fix double free of a TUR followed by a solicited NOPOUT
commit 9547308bda296b6f69876c840a0291fcfbeddbb8 upstream.
Make sure all non-READ SCSI commands get targ_xfer_tag initialized
to 0xffffffff, not just WRITEs.
Double-free of a TUR cmd object occurs under the following scenario:
1. TUR received (targ_xfer_tag is uninitialized and left at 0)
2. TUR status sent
3. First unsolicited NOPIN is sent to initiator (gets targ_xfer_tag of 0)
4. NOPOUT for NOPIN (with TTT=0) arrives
- its ExpStatSN acks TUR status, TUR is queued for removal
- LIO tries to find NOPIN with TTT=0, but finds the same TUR instead,
TUR is queued for removal for the 2nd time
(Drop unbalanced conditional bracket usage - nab)
Signed-off-by: Alexei Potashnik <alexei@purestorage.com>
Signed-off-by: Spencer Baugh <sbaugh@catern.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
[lizf: Backported to 3.4:
- adjust context
- leave the braces as it is]
Signed-off-by: Zefan Li <lizefan@huawei.com>
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions