diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2016-06-07 21:26:55 -0400 |
---|---|---|
committer | Sasha Levin <sasha.levin@oracle.com> | 2016-06-19 23:47:45 -0400 |
commit | 34558d3f213b5d95253aba97b529d46f20b757cb (patch) | |
tree | 348cc05eb58b30c998c2cbd120c74a39fb0ad95b /net/unix/af_unix.c | |
parent | d05438b3ba85517631b5ea2e1c88172f84dffe8b (diff) |
fix d_walk()/non-delayed __d_free() race
[ Upstream commit 3d56c25e3bb0726a5c5e16fc2d9e38f8ed763085 ]
Ascend-to-parent logics in d_walk() depends on all encountered child
dentries not getting freed without an RCU delay. Unfortunately, in
quite a few cases it is not true, with hard-to-hit oopsable race as
the result.
Fortunately, the fix is simiple; right now the rule is "if it ever
been hashed, freeing must be delayed" and changing it to "if it
ever had a parent, freeing must be delayed" closes that hole and
covers all cases the old rule used to cover. Moreover, pipes and
sockets remain _not_ covered, so we do not introduce RCU delay in
the cases which are the reason for having that delay conditional
in the first place.
Cc: stable@vger.kernel.org # v3.2+ (and watch out for __d_materialise_dentry())
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions