diff options
author | lucien <lucien.xin@gmail.com> | 2015-08-27 04:52:20 +0800 |
---|---|---|
committer | Zefan Li <lizefan@huawei.com> | 2016-03-21 09:17:53 +0800 |
commit | 1f2a65a223b690c8b71f22d0c9bc6851324e6073 (patch) | |
tree | 3c33d145f4dd88f8e622af47c2d00675f1a56c2e /net/unix/af_unix.c | |
parent | 0ddb79b0efb4d01fbeab9aadf31d85850630d089 (diff) |
sctp: donot reset the overall_error_count in SHUTDOWN_RECEIVE state
commit f648f807f61e64d247d26611e34cc97e4ed03401 upstream.
Commit f8d960524328 ("sctp: Enforce retransmission limit during shutdown")
fixed a problem with excessive retransmissions in the SHUTDOWN_PENDING by not
resetting the association overall_error_count. This allowed the association
to better enforce assoc.max_retrans limit.
However, the same issue still exists when the association is in SHUTDOWN_RECEIVED
state. In this state, HB-ACKs will continue to reset the overall_error_count
for the association would extend the lifetime of association unnecessarily.
This patch solves this by resetting the overall_error_count whenever the current
state is small then SCTP_STATE_SHUTDOWN_PENDING. As a small side-effect, we
end up also handling SCTP_STATE_SHUTDOWN_ACK_SENT and SCTP_STATE_SHUTDOWN_SENT
states, but they are not really impacted because we disable Heartbeats in those
states.
Fixes: Commit f8d960524328 ("sctp: Enforce retransmission limit during shutdown")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Zefan Li <lizefan@huawei.com>
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions