diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2025-01-09 16:49:24 -0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-01-10 18:37:01 -0800 |
| commit | 21520e74ba454c549f4f732d014f180f8c0c041c (patch) | |
| tree | de81f4fbdc422e9090b83e8dfa58d4aab1e95f3e /net/core | |
| parent | af3525d41001431e3d170214170dfe7dd73435b9 (diff) | |
net: hide the definition of dev_get_by_napi_id()
There are no module callers of dev_get_by_napi_id(),
and commit d1cacd747768 ("netdev: prevent accessing NAPI instances
from another namespace") proves that getting NAPI by id
needs to be done with care. So hide dev_get_by_napi_id().
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Joe Damato <jdamato@fastly.com>
Link: https://patch.msgid.link/20250110004924.3212260-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/core')
| -rw-r--r-- | net/core/dev.c | 2 | ||||
| -rw-r--r-- | net/core/dev.h | 1 |
2 files changed, 1 insertions, 2 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 4452ca2c91ea6..1a90ed8cc6cc2 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -957,7 +957,6 @@ EXPORT_SYMBOL(netdev_get_by_index); * its reference counter increased so the caller must be careful * about locking. The caller must hold RCU lock. */ - struct net_device *dev_get_by_napi_id(unsigned int napi_id) { struct napi_struct *napi; @@ -971,7 +970,6 @@ struct net_device *dev_get_by_napi_id(unsigned int napi_id) return napi ? napi->dev : NULL; } -EXPORT_SYMBOL(dev_get_by_napi_id); static DEFINE_SEQLOCK(netdev_rename_lock); diff --git a/net/core/dev.h b/net/core/dev.h index 08812a025a9b1..d8966847794ce 100644 --- a/net/core/dev.h +++ b/net/core/dev.h @@ -23,6 +23,7 @@ struct sd_flow_limit { extern int netdev_flow_limit_table_len; struct napi_struct *netdev_napi_by_id(struct net *net, unsigned int napi_id); +struct net_device *dev_get_by_napi_id(unsigned int napi_id); #ifdef CONFIG_PROC_FS int __init dev_proc_init(void); |