diff options
| author | Andy Spencer <aspencer@spacex.com> | 2018-02-22 11:05:33 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-01-27 08:47:42 +0100 |
| commit | 8d18509bd36cdc4e620b9dee83b863ca647cbbfa (patch) | |
| tree | d1047a85bd4da0f9ded662706955050e60a00d84 /lib/timerqueue.c | |
| parent | 70f44dfbde027f444412cfb4ea9b485a4c1dec0e (diff) | |
gianfar: simplify FCS handling and fix memory leak
commit d903ec77118c09f93a610b384d83a6df33a64fe6 upstream.
Previously, buffer descriptors containing only the frame check sequence
(FCS) were skipped and not added to the skb. However, the page reference
count was still incremented, leading to a memory leak.
Fixing this inside gfar_add_rx_frag() is difficult due to reserved
memory handling and page reuse. Instead, move the FCS handling to
gfar_process_frame() and trim off the FCS before passing the skb up the
networking stack.
Signed-off-by: Andy Spencer <aspencer@spacex.com>
Signed-off-by: Jim Gruen <jgruen@spacex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib/timerqueue.c')
0 files changed, 0 insertions, 0 deletions