diff options
| author | Kanchan Joshi <joshi.k@samsung.com> | 2025-05-07 00:18:43 +0530 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2025-05-06 13:46:36 -0600 |
| commit | f3c308b9d13ace45955e8406e3008f640f01faae (patch) | |
| tree | 585d867e62ec79332bdc06df3ba5a3fce687c229 /drivers/nvme/host/core.c | |
| parent | 86b6e0bd1a69efd0ed408997e0adfb85df96a0c7 (diff) | |
nvme: fix incorrect sizeof
The plid array, head->plids, is meant to store placement IDs, each of
type u16. But its size has been incorrectly calculated, as the size of
the pointer is being used instead of the size of the object it points
to.
Use the sizeof(*head->plids) in kcalloc so that we don't allocate extra.
Fixes: 38e8397dde63 ("nvme: use fdp streams if write stream is provided")
Reported-by: Caleb Sander Mateos <csander@purestorage.com>
Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
Reviewed-by: Caleb Sander Mateos <csander@purestorage.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/nvme/host/core.c')
| -rw-r--r-- | drivers/nvme/host/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index a9fb8cd54420..a8444d1e8398 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -2296,7 +2296,7 @@ static int nvme_query_fdp_info(struct nvme_ns *ns, struct nvme_ns_info *info) if (!head->nr_plids) goto free; - head->plids = kcalloc(head->nr_plids, sizeof(head->plids), + head->plids = kcalloc(head->nr_plids, sizeof(*head->plids), GFP_KERNEL); if (!head->plids) { dev_warn(ctrl->device, |