diff options
| author | Colin Ian King <colin.king@canonical.com> | 2018-10-06 14:01:42 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-11-25 15:54:49 +0100 |
| commit | 0e74fb6274ff2465205616997465d7b26b29a664 (patch) | |
| tree | 96e95a08a9ee9b4d97a8184da8900eb07cd3a150 /drivers/hwmon/pwm-fan.c | |
| parent | 560976f5b8d068d92251de339b2794aae5f59d76 (diff) | |
media: cx231xx: fix potential sign-extension overflow on large shift
[ Upstream commit 32ae592036d7aeaabcccb2b1715373a68639a768 ]
Shifting the u8 value[3] by an int can lead to sign-extension
overflow. For example, if value[3] is 0xff and the shift is 24 then it
is promoted to int and then the top bit is sign-extended so that all
upper 32 bits are set. Fix this by casting value[3] to a u32 before
the shift.
Detected by CoverityScan, CID#1016522 ("Unintended sign extension")
Fixes: e0d3bafd0258 ("V4L/DVB (10954): Add cx231xx USB driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/hwmon/pwm-fan.c')
0 files changed, 0 insertions, 0 deletions