diff options
| author | Bolarinwa Olayemi Saheed <refactormyself@gmail.com> | 2020-07-13 19:55:27 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-08-21 09:48:05 +0200 |
| commit | eaa75754757e352a5121f5dfca5fa5be5376b3cb (patch) | |
| tree | bcff80fcd0af36198f122889ec6dbc58ffd0d80f /drivers/gpu/host1x/debug.c | |
| parent | ccf28790086cd6b27e33d02f1f185572fa89c07b (diff) | |
iwlegacy: Check the return value of pcie_capability_read_*()
[ Upstream commit 9018fd7f2a73e9b290f48a56b421558fa31e8b75 ]
On failure pcie_capability_read_dword() sets it's last parameter, val
to 0. However, with Patch 14/14, it is possible that val is set to ~0 on
failure. This would introduce a bug because (x & x) == (~0 & x).
This bug can be avoided without changing the function's behaviour if the
return value of pcie_capability_read_dword is checked to confirm success.
Check the return value of pcie_capability_read_dword() to ensure success.
Suggested-by: Bjorn Helgaas <bjorn@helgaas.com>
Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200713175529.29715-3-refactormyself@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/gpu/host1x/debug.c')
0 files changed, 0 insertions, 0 deletions