diff options
| author | Jiri Slaby <jslaby@suse.cz> | 2022-05-03 10:08:03 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-06-09 10:26:29 +0200 |
| commit | dd1f20f50dc3fcdd5225dc2c814fa1c8129c8fc8 (patch) | |
| tree | 9a0c7659f6919a30ca87604e8f3577ccb1f728c8 /drivers/gpu/drm/tilcdc/tilcdc_external.c | |
| parent | 6332ea3e35efa12dc08f0cbf5faea5e6e8eb0497 (diff) | |
serial: pch: don't overwrite xmit->buf[0] by x_char
commit d9f3af4fbb1d955bbaf872d9e76502f6e3e803cb upstream.
When x_char is to be sent, the TX path overwrites whatever is in the
circular buffer at offset 0 with x_char and sends it using
pch_uart_hal_write(). I don't understand how this was supposed to work
if xmit->buf[0] already contained some character. It must have been
lost.
Remove this whole pop_tx_x() concept and do the work directly in the
callers. (Without printing anything using dev_dbg().)
Cc: <stable@vger.kernel.org>
Fixes: 3c6a483275f4 (Serial: EG20T: add PCH_UART driver)
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20220503080808.28332-1-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/gpu/drm/tilcdc/tilcdc_external.c')
0 files changed, 0 insertions, 0 deletions