summaryrefslogtreecommitdiff
path: root/drivers/cdx/controller/cdx_controller.h
diff options
context:
space:
mode:
authorWei Fang <wei.fang@nxp.com>2024-05-11 14:20:09 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-05-30 09:44:39 +0200
commit87bcbc9b7e0b43a69d44efa5f32f11e32d08fa6f (patch)
tree7931fe9cf73d2b8d57e75923493d0c5762880a05 /drivers/cdx/controller/cdx_controller.h
parent0aca9ef921fe24257efb2210dabaf1dcb04dfa05 (diff)
net: fec: remove .ndo_poll_controller to avoid deadlocks
[ Upstream commit c2e0c58b25a0a0c37ec643255558c5af4450c9f5 ] There is a deadlock issue found in sungem driver, please refer to the commit ac0a230f719b ("eth: sungem: remove .ndo_poll_controller to avoid deadlocks"). The root cause of the issue is that netpoll is in atomic context and disable_irq() is called by .ndo_poll_controller interface of sungem driver, however, disable_irq() might sleep. After analyzing the implementation of fec_poll_controller(), the fec driver should have the same issue. Due to the fec driver uses NAPI for TX completions, the .ndo_poll_controller is unnecessary to be implemented in the fec driver, so fec_poll_controller() can be safely removed. Fixes: 7f5c6addcdc0 ("net/fec: add poll controller function for fec nic") Signed-off-by: Wei Fang <wei.fang@nxp.com> Link: https://lore.kernel.org/r/20240511062009.652918-1-wei.fang@nxp.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/cdx/controller/cdx_controller.h')
0 files changed, 0 insertions, 0 deletions