summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthew Wilcox (Oracle) <willy@infradead.org>2024-07-09 20:58:39 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-07-18 13:22:39 +0200
commitfbd4f53c11ddb4df90b10dadfdb2e46092d39122 (patch)
tree7561fc11a6a1dcf76ca648c87f731ab539b98aab
parent84aaaa796a19195fc59290154fef9aeb1fba964f (diff)
minixfs: Fix minixfs_rename with HIGHMEM
[ Upstream commit 3d1bec293378700dddc087d4d862306702276c23 ] minixfs now uses kmap_local_page(), so we can't call kunmap() to undo it. This one call was missed as part of the commit this fixes. Fixes: 6628f69ee66a (minixfs: Use dir_put_page() in minix_unlink() and minix_rename()) Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Link: https://lore.kernel.org/r/20240709195841.1986374-1-willy@infradead.org Signed-off-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--fs/minix/namei.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/minix/namei.c b/fs/minix/namei.c
index d6031acc34f0..a944a0f17b53 100644
--- a/fs/minix/namei.c
+++ b/fs/minix/namei.c
@@ -213,8 +213,7 @@ static int minix_rename(struct mnt_idmap *idmap,
if (!new_de)
goto out_dir;
err = minix_set_link(new_de, new_page, old_inode);
- kunmap(new_page);
- put_page(new_page);
+ unmap_and_put_page(new_page, new_de);
if (err)
goto out_dir;
inode_set_ctime_current(new_inode);