diff options
| author | Ulf Hansson <ulf.hansson@linaro.org> | 2025-06-10 13:16:26 +0200 |
|---|---|---|
| committer | Ulf Hansson <ulf.hansson@linaro.org> | 2025-06-24 12:43:26 +0200 |
| commit | f9a1a9448f5c12a24c3724a4899e34a22b90e7f1 (patch) | |
| tree | 1a2e4e2ba1d165c6bc062284bba845f574c461b9 | |
| parent | 55131d685ebee43d7f7260f34459201734ee6a44 (diff) | |
mmc: rtsx_usb_sdmmc: Re-work the code in sd_set_power_mode()
It's only at MMC_POWER_OFF and at MMC_POWER_UP when some operations must be
carried out in sd_set_power_mode(). The code is a bit obfuscated in this
regards. Let's convert it into a switch-case-clause to make this clear.
Reviewed-by: Avri Altman <avri.altman@sandisk.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Ricky Wu <ricky_wu@realtek.com>
Link: https://lore.kernel.org/r/20250610111633.504366-5-ulf.hansson@linaro.org
| -rw-r--r-- | drivers/mmc/host/rtsx_usb_sdmmc.c | 18 |
1 files changed, 13 insertions, 5 deletions
diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c index 676f08f71ec0..b750e2166d92 100644 --- a/drivers/mmc/host/rtsx_usb_sdmmc.c +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c @@ -1015,22 +1015,30 @@ static void sd_set_power_mode(struct rtsx_usb_sdmmc *host, { int err; - if (power_mode != MMC_POWER_OFF) - power_mode = MMC_POWER_ON; - if (power_mode == host->power_mode) return; - if (power_mode == MMC_POWER_OFF) { + switch (power_mode) { + case MMC_POWER_OFF: err = sd_power_off(host); if (err) dev_dbg(sdmmc_dev(host), "power-off (err = %d)\n", err); pm_runtime_put_noidle(sdmmc_dev(host)); - } else { + break; + + case MMC_POWER_UP: pm_runtime_get_noresume(sdmmc_dev(host)); err = sd_power_on(host); if (err) dev_dbg(sdmmc_dev(host), "power-on (err = %d)\n", err); + break; + + case MMC_POWER_ON: + case MMC_POWER_UNDEFINED: + break; + + default: + break; } host->power_mode = power_mode; |