diff options
| author | Frank Rowand <frank.rowand@sony.com> | 2020-03-25 20:45:30 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-02-23 08:25:15 +0100 |
| commit | e9aa8e5a72bdfab3c28fd78a0fd83da38b5ff1c2 (patch) | |
| tree | 25b5157ae472c1c3d09d0dbffa09f07139bd52a3 | |
| parent | 6ac8965955fa418eadbf21987d83e97be13bc4a8 (diff) | |
of: gpio unittest kfree() wrong object
commit fb227f597d612c6660888d1947e68a25fed7b9cc upstream.
kernel test robot reported "WARNING: held lock freed!" triggered by
unittest_gpio_remove(). unittest_gpio_remove() was unexpectedly
called due to an error in overlay tracking. The remove had not
been tested because the gpio overlay removal tests have not been
implemented.
kfree() gdev instead of pdev.
Fixes: f4056e705b2e ("of: unittest: add overlay gpio test to catch gpio hog problem")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/of/unittest.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 3443bedb0e0b..f1aa09215d4b 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -124,7 +124,7 @@ static int unittest_gpio_remove(struct platform_device *pdev) gpiochip_remove(&gdev->chip); platform_set_drvdata(pdev, NULL); - kfree(pdev); + kfree(gdev); return 0; } |