diff options
| author | Pali Rohár <pali@kernel.org> | 2024-09-12 15:06:22 +0200 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2024-11-25 14:50:32 -0600 |
| commit | d3d797e326533794c3f707ce1761da7a8895458c (patch) | |
| tree | 18514ab27f2eba6d32b8103b6a58038969f7785d | |
| parent | 06a7adf318a30bdcfa1222ed6d2640e6bb266d7b (diff) | |
cifs: Improve guard for excluding $LXDEV xattr
$LXDEV xattr is for storing block/char device's major and minor number.
Change guard which excludes storing $LXDEV xattr to explicitly filter
everything except block and char device. Current guard is opposite, which
is currently correct but is less-safe. This change is required for adding
support for creating WSL-style symlinks as symlinks also do not use
device's major and minor numbers.
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/smb/client/reparse.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/smb/client/reparse.c b/fs/smb/client/reparse.c index 722c9beb8fa6..732b3b51128b 100644 --- a/fs/smb/client/reparse.c +++ b/fs/smb/client/reparse.c @@ -378,8 +378,8 @@ static int wsl_set_xattrs(struct inode *inode, umode_t _mode, memset(iov, 0, sizeof(*iov)); - /* Exclude $LXDEV xattr for sockets and fifos */ - if (S_ISSOCK(_mode) || S_ISFIFO(_mode)) + /* Exclude $LXDEV xattr for non-device files */ + if (!S_ISBLK(_mode) && !S_ISCHR(_mode)) num_xattrs = ARRAY_SIZE(xattrs) - 1; else num_xattrs = ARRAY_SIZE(xattrs); |