diff options
| author | Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> | 2024-12-16 19:56:24 +0200 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2025-02-18 15:40:54 -0600 |
| commit | c8098ad8fb2e80dcb92920da795455d30ed5e292 (patch) | |
| tree | 9dddde81908a933b55f8db52ed980b9de5964ffa | |
| parent | ca9097f9ce0383e46588bc96bda8f65b57d5d125 (diff) | |
PCI: Remove incorrect comment from pci_reassign_resource()
Commit a4ac9fea016f ("PCI : Calculate right add_size") removed including
min_align into new_size in pci_reassign_resource() which is the correct
thing to do. However, it also added a snakeoil comment that the resource
would already be aligned with min_align which is incorrect.
A resource that is assigned earlier is aligned with the old alignment, NOT
with the new requested alignment (min_align) until later deep within the
reassignment callchain. Thus, remove the incorrect comment.
Link: https://lore.kernel.org/r/20241216175632.4175-18-ilpo.jarvinen@linux.intel.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Tested-by: Xiaochun Lee <lixc17@lenovo.com>
Cc: Yinghai Lu <yinghai@kernel.org>
| -rw-r--r-- | drivers/pci/setup-res.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c index 83ffff7cc0a3..51ff9ab1f400 100644 --- a/drivers/pci/setup-res.c +++ b/drivers/pci/setup-res.c @@ -387,7 +387,6 @@ int pci_reassign_resource(struct pci_dev *dev, int resno, return -EINVAL; } - /* already aligned with min_align */ new_size = resource_size(res) + addsize; ret = _pci_assign_resource(dev, resno, new_size, min_align); if (ret) { |