diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2025-05-08 23:38:01 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-08-20 18:40:56 +0200 |
| commit | c2ef81f8e81bff7ddea9d29866eccec0d6a2a398 (patch) | |
| tree | 04c656ae51849e325679826f9dcfaff5c092d2b4 | |
| parent | 368f2d444193d2c570a81ceef3853088e6f96fd7 (diff) | |
securityfs: don't pin dentries twice, once is enough...
[ Upstream commit 27cd1bf1240d482e4f02ca4f9812e748f3106e4f ]
incidentally, securityfs_recursive_remove() is broken without that -
it leaks dentries, since simple_recursive_removal() does not expect
anything of that sort. It could be worked around by dput() in
remove_one() callback, but it's easier to just drop that double-get
stuff.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | security/inode.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/security/inode.c b/security/inode.c index 3913501621fa..93460eab8216 100644 --- a/security/inode.c +++ b/security/inode.c @@ -159,7 +159,6 @@ static struct dentry *securityfs_create_dentry(const char *name, umode_t mode, inode->i_fop = fops; } d_instantiate(dentry, inode); - dget(dentry); inode_unlock(dir); return dentry; @@ -306,7 +305,6 @@ void securityfs_remove(struct dentry *dentry) simple_rmdir(dir, dentry); else simple_unlink(dir, dentry); - dput(dentry); } inode_unlock(dir); simple_release_fs(&mount, &mount_count); |