summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXiao Yang <yangx.jy@fujitsu.com>2022-04-10 19:35:13 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-06-09 10:21:31 +0200
commitbb55ca1612923b06c4d86ab28b8dd8fdca55ced1 (patch)
tree9ab33f89a72298cb67e5e6ed86968bea42a6362f
parent72268945b124cd61336f9b4cac538b0516399a2d (diff)
RDMA/rxe: Generate a completion for unsupported/invalid opcode
commit 2f917af777011c88e977b9b9a5d00b280d3a59ce upstream. Current rxe_requester() doesn't generate a completion when processing an unsupported/invalid opcode. If rxe driver doesn't support a new opcode (e.g. RDMA Atomic Write) and RDMA library supports it, an application using the new opcode can reproduce this issue. Fix the issue by calling "goto err;". Fixes: 8700e3e7c485 ("Soft RoCE driver") Link: https://lore.kernel.org/r/20220410113513.27537-1-yangx.jy@fujitsu.com Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/infiniband/sw/rxe/rxe_req.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
index d4917646641a..69238f856c67 100644
--- a/drivers/infiniband/sw/rxe/rxe_req.c
+++ b/drivers/infiniband/sw/rxe/rxe_req.c
@@ -650,7 +650,7 @@ next_wqe:
opcode = next_opcode(qp, wqe, wqe->wr.opcode);
if (unlikely(opcode < 0)) {
wqe->status = IB_WC_LOC_QP_OP_ERR;
- goto exit;
+ goto err;
}
mask = rxe_opcode[opcode].mask;