diff options
| author | Zijun Hu <quic_zijuhu@quicinc.com> | 2025-02-24 17:01:55 -0600 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-05-02 07:58:55 +0200 |
| commit | a122b3b1f5b88036eaaa10ca4348ffabf5ae339f (patch) | |
| tree | c3bf924074444214449d6fa3d7011127dc0136dd | |
| parent | 05576e1304fd964468d2388c784c4c5ca6151434 (diff) | |
of: resolver: Fix device node refcount leakage in of_resolve_phandles()
[ Upstream commit a46a0805635d07de50c2ac71588345323c13b2f9 ]
In of_resolve_phandles(), refcount of device node @local_fixups will be
increased if the for_each_child_of_node() exits early, but nowhere to
decrease the refcount, so cause refcount leakage for the node.
Fix by using __free() on @local_fixups.
Fixes: da56d04c806a ("of/resolver: Switch to new local fixups format.")
Cc: stable@vger.kernel.org
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20250209-of_irq_fix-v2-9-93e3a2659aa7@quicinc.com
[robh: Use __free() instead]
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/of/resolver.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index fce8bdac45f3..7d935908b543 100644 --- a/drivers/of/resolver.c +++ b/drivers/of/resolver.c @@ -249,8 +249,9 @@ static int adjust_local_phandle_references(struct device_node *local_fixups, */ int of_resolve_phandles(struct device_node *overlay) { - struct device_node *child, *local_fixups, *refnode; + struct device_node *child, *refnode; struct device_node *overlay_fixups; + struct device_node __free(device_node) *local_fixups = NULL; struct property *prop; const char *refpath; phandle phandle, phandle_delta; |