diff options
| author | Dimitri Fedrau <dimitri.fedrau@liebherr.com> | 2025-03-17 08:48:34 +0100 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-03-24 09:52:36 -0700 |
| commit | 8fa649fd7d3009769c7289d0c31c319b72bc42c4 (patch) | |
| tree | 5dc1b1b92dcb2e68eb9a4ba95901162c424bafdf | |
| parent | d39e08b0893b579ba1fdee5713d011a4585517f7 (diff) | |
net: phy: dp83822: fix transmit amplitude if CONFIG_OF_MDIO not defined
When CONFIG_OF_MDIO is not defined the index for selecting the transmit
amplitude voltage for 100BASE-TX is set to 0, but it should be -1, if there
is no need to modify the transmit amplitude voltage. Move initialization of
the index from dp83822_of_init to dp8382x_probe.
Fixes: 4f3735e82d8a ("net: phy: dp83822: Add support for changing the transmit amplitude voltage")
Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>
Signed-off-by: Dimitri Fedrau <dimitri.fedrau@liebherr.com>
Link: https://patch.msgid.link/20250317-dp83822-fix-transceiver-mdio-v2-1-fb09454099a4@liebherr.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/phy/dp83822.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c index 3662f3905d5a..14f361549638 100644 --- a/drivers/net/phy/dp83822.c +++ b/drivers/net/phy/dp83822.c @@ -833,7 +833,6 @@ static int dp83822_of_init(struct phy_device *phydev) dp83822->set_gpio2_clk_out = true; } - dp83822->tx_amplitude_100base_tx_index = -1; ret = phy_get_tx_amplitude_gain(phydev, dev, ETHTOOL_LINK_MODE_100baseT_Full_BIT, &val); @@ -931,6 +930,7 @@ static int dp8382x_probe(struct phy_device *phydev) if (!dp83822) return -ENOMEM; + dp83822->tx_amplitude_100base_tx_index = -1; phydev->priv = dp83822; return 0; |