summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilipe Manana <fdmanana@suse.com>2025-02-18 15:52:22 +0000
committerDavid Sterba <dsterba@suse.com>2025-03-18 20:35:46 +0100
commit892772c3896dee58dbd1dd287fdae72e5551ad8c (patch)
tree6ccfac4692604da64c244725c821bdaaa4f97905
parent43090f2ca9e0153a644f86fb6c4f38e6034b4be3 (diff)
btrfs: send: simplify return logic from record_changed_ref()
There is no need to have an 'out' label and jump into it since there are no resource cleanups to perform (release locks, free memory, etc), so make this simpler by removing the label and goto and instead return directly. Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
-rw-r--r--fs/btrfs/send.c10
1 files changed, 4 insertions, 6 deletions
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index 6e171b504415c..01b8b570d6ed3 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -4766,20 +4766,18 @@ static int record_deleted_ref(struct send_ctx *sctx)
static int record_changed_ref(struct send_ctx *sctx)
{
- int ret = 0;
+ int ret;
ret = iterate_inode_ref(sctx->send_root, sctx->left_path,
sctx->cmp_key, 0, record_new_ref_if_needed, sctx);
if (ret < 0)
- goto out;
+ return ret;
ret = iterate_inode_ref(sctx->parent_root, sctx->right_path,
sctx->cmp_key, 0, record_deleted_ref_if_needed, sctx);
if (ret < 0)
- goto out;
- ret = 0;
+ return ret;
-out:
- return ret;
+ return 0;
}
/*