summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBartosz Golaszewski <bgolaszewski@baylibre.com>2020-09-08 15:07:49 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-11-22 10:00:24 +0100
commit85a56167784e52a5c99cd8ef0b14b01aec453f54 (patch)
tree2facb40fac6b60fcdf8d264262680c891bc4f3c9
parent7dd0051f6b85ce19140c64b130d6eb89f1830749 (diff)
gpio: mockup: fix resource leak in error path
commit 1b02d9e770cd7087f34c743f85ccf5ea8372b047 upstream If the module init function fails after creating the debugs directory, it's never removed. Add proper cleanup calls to avoid this resource leak. Fixes: 9202ba2397d1 ("gpio: mockup: implement event injecting over debugfs") Cc: <stable@vger.kernel.org> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> [sudip: adjust context] Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/gpio/gpio-mockup.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index d99c8d8da9a0..a09a1334afbf 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -350,6 +350,7 @@ static int __init mock_device_init(void)
err = platform_driver_register(&gpio_mockup_driver);
if (err) {
platform_device_unregister(pdev);
+ debugfs_remove_recursive(gpio_mockup_dbg_dir);
return err;
}