diff options
| author | Joe Damato <jdamato@fastly.com> | 2024-11-14 17:51:56 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-12-05 13:54:22 +0100 |
| commit | 8544602fb6cd5893996d014ce92b73a538a14e4d (patch) | |
| tree | 3686ff1c41ddd29fb116fb2a1163379e43247abb | |
| parent | 7a9d083a7d1fe794e357e7b2dbfd2a2c184f4496 (diff) | |
netdev-genl: Hold rcu_read_lock in napi_get
commit c53bf100f68619acf6cedcf4cf5249a1ca2db0b4 upstream.
Hold rcu_read_lock in netdev_nl_napi_get_doit, which calls napi_by_id
and is required to be called under rcu_read_lock.
Cc: stable@vger.kernel.org
Fixes: 27f91aaf49b3 ("netdev-genl: Add netlink framework functions for napi")
Signed-off-by: Joe Damato <jdamato@fastly.com>
Link: https://patch.msgid.link/20241114175157.16604-1-jdamato@fastly.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | net/core/netdev-genl.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c index a17d7eaeb001..f8f8c1e50ae4 100644 --- a/net/core/netdev-genl.c +++ b/net/core/netdev-genl.c @@ -214,6 +214,7 @@ int netdev_nl_napi_get_doit(struct sk_buff *skb, struct genl_info *info) return -ENOMEM; rtnl_lock(); + rcu_read_lock(); napi = napi_by_id(napi_id); if (napi) { @@ -223,6 +224,7 @@ int netdev_nl_napi_get_doit(struct sk_buff *skb, struct genl_info *info) err = -ENOENT; } + rcu_read_unlock(); rtnl_unlock(); if (err) |