diff options
| author | Kuniyuki Iwashima <kuniyu@google.com> | 2025-09-27 21:29:39 +0000 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-09-29 18:41:06 -0700 |
| commit | 70dd4775db7fe33669bff6998e4b363298810127 (patch) | |
| tree | 6e906e3fcd5e2712f26d472fe8e1f4b00311c953 | |
| parent | 4ed9db2dc5d8981ecb7042f084f5cff43ba539d6 (diff) | |
selftest: packetdrill: Set ktap_set_plan properly for single protocol test.
The cited commit forgot to update the ktap_set_plan call.
ktap_set_plan sets the number of tests (KSFT_NUM_TESTS), which must
match the number of executed tests (KTAP_CNT_PASS + KTAP_CNT_SKIP +
KTAP_CNT_XFAIL) in ktap_finished.
Otherwise, the selftest exit()s with 1.
Let's adjust KSFT_NUM_TESTS based on supported protocols.
While at it, misalignment is fixed up.
Fixes: a5c10aa3d1ba ("selftests/net: packetdrill: Support single protocol test.")
Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20250927213022.1850048-2-kuniyu@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rwxr-xr-x | tools/testing/selftests/net/packetdrill/ksft_runner.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/testing/selftests/net/packetdrill/ksft_runner.sh b/tools/testing/selftests/net/packetdrill/ksft_runner.sh index 0ae6eeeb1a8e..3fa7c7f66caf 100755 --- a/tools/testing/selftests/net/packetdrill/ksft_runner.sh +++ b/tools/testing/selftests/net/packetdrill/ksft_runner.sh @@ -48,11 +48,11 @@ elif [[ ! "$ip_versions" =~ ^ipv[46]$ ]]; then fi ktap_print_header -ktap_set_plan 2 +ktap_set_plan $(echo $ip_versions | wc -w) for ip_version in $ip_versions; do unshare -n packetdrill ${ip_args[$ip_version]} ${optargs[@]} $script > /dev/null \ - && ktap_test_pass $ip_version || $failfunc $ip_version + && ktap_test_pass $ip_version || $failfunc $ip_version done ktap_finished |