diff options
| author | Takashi Iwai <tiwai@suse.de> | 2024-12-30 12:40:22 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-01-09 13:33:48 +0100 |
| commit | 56432f68451337885ce189bf8e5a8b92587c4f1a (patch) | |
| tree | 0fa29137a5d29c0db39e2f56a3ae3d10ce45b8bc | |
| parent | a93c6cf0868fbbf743343db221ab3e05638310c6 (diff) | |
Revert "ALSA: ump: Don't enumeration invalid groups for legacy rawmidi"
commit abbff41b6932cde359589fd51f4024b7c85f366b upstream.
This reverts commit c2d188e137e77294323132a760a4608321a36a70.
Although it's fine to filter the invalid UMP groups at the first probe
time, this will become a problem when UMP groups are updated and
(re-)activated. Then there is no way to re-add the substreams
properly for the legacy rawmidi, and the new active groups will be
still invisible.
So let's revert the change. This will move back to showing the full
16 groups, but it's better than forever lost.
Link: https://patch.msgid.link/20241230114023.3787-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | sound/core/ump.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/core/ump.c b/sound/core/ump.c index bd26bb2210cb..abc537d54b73 100644 --- a/sound/core/ump.c +++ b/sound/core/ump.c @@ -1244,7 +1244,7 @@ static int fill_legacy_mapping(struct snd_ump_endpoint *ump) num = 0; for (i = 0; i < SNDRV_UMP_MAX_GROUPS; i++) - if ((group_maps & (1U << i)) && ump->groups[i].valid) + if (group_maps & (1U << i)) ump->legacy_mapping[num++] = i; return num; |