summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJames C Boyd <jcboyd.dev@gmail.com>2015-05-27 17:09:06 -0500
committerBen Hutchings <ben@decadent.org.uk>2017-04-04 22:21:56 +0100
commit4e54d5d95fc4156cedebb7286abc932ad628690c (patch)
tree91e7246f048657a2f772b469680f9191ab0fba87
parent4c125b48deacb51dbe5618ba5c1cfec9bcc41e6e (diff)
HID: hid-input: Add parentheses to quell gcc warning
commit 09a5c34e8d6b05663ec4c3d22b1fbd9fec89aaf9 upstream. GCC reports a -Wlogical-not-parentheses warning here; therefore add parentheses to shut it up and to express our intent more. Signed-off-by: James C Boyd <jcboyd.dev@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Cc: Arnd Bergmann <arnd@arndb.de>
-rw-r--r--drivers/hid/hid-input.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 197128ed8225..ee1af4565828 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -1119,7 +1119,7 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
return;
/* report the usage code as scancode if the key status has changed */
- if (usage->type == EV_KEY && !!test_bit(usage->code, input->key) != value)
+ if (usage->type == EV_KEY && (!!test_bit(usage->code, input->key)) != value)
input_event(input, EV_MSC, MSC_SCAN, usage->hid);
input_event(input, usage->type, usage->code, value);