diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-04-23 11:23:53 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-04-25 13:22:25 +0200 |
| commit | 4c0fca65d10548f68c040ed49bf1860ce0dda9b9 (patch) | |
| tree | 8e6ae507d06faa06d42d875f40d3cb6b9e6153ac | |
| parent | 45ebb7baf2356c3d9118c40216ad5b3d0d516b15 (diff) | |
usb: dwc3: qcom: Fix error handling in probe
There are two issues:
1) Return -EINVAL if platform_get_resource() fails. Don't return
success.
2) The devm_ioremap() function doesn't return error pointers, it returns
NULL. Update the check.
Fixes: 1881a32fe14d ("usb: dwc3: qcom: Transition to flattened model")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/aAijmfAph0FlTqg6@stanley.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/usb/dwc3/dwc3-qcom.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index cbba11589cd0..20c00ba3bc3d 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -740,15 +740,17 @@ static int dwc3_qcom_probe(struct platform_device *pdev) } r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) + if (!r) { + ret = -EINVAL; goto clk_disable; + } res = *r; res.end = res.start + SDM845_QSCRATCH_BASE_OFFSET; qcom->qscratch_base = devm_ioremap(dev, res.end, SDM845_QSCRATCH_SIZE); - if (IS_ERR(qcom->qscratch_base)) { - dev_err(dev, "failed to map qscratch region: %pe\n", qcom->qscratch_base); - ret = PTR_ERR(qcom->qscratch_base); + if (!qcom->qscratch_base) { + dev_err(dev, "failed to map qscratch region\n"); + ret = -ENOMEM; goto clk_disable; } |