diff options
| author | Thomas Weißschuh <linux@weissschuh.net> | 2025-06-17 19:08:13 +0200 |
|---|---|---|
| committer | Boqun Feng <boqun.feng@gmail.com> | 2025-07-11 15:11:19 -0700 |
| commit | 3b07bb900af7f43f13f9ff398b4c6ca1dee217cd (patch) | |
| tree | 5a2c5e9b6d21fddcb6273ba2faee92e80254f962 | |
| parent | d24a54e032021cf381af3c3cf119cc5cf6b3c1be (diff) | |
leds: lp8860: Check return value of devm_mutex_init()
devm_mutex_init() can fail. With CONFIG_DEBUG_MUTEXES=y the mutex will be
marked as unusable and trigger errors on usage.
Add the missed check.
Fixes: 87a59548af95 ("leds: lp8860: Use new mutex guards to cleanup function exits")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Acked-by: Andrew Davis <afd@ti.com>
Acked-by: Lee Jones <lee@kernel.org>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20250617-must_check-devm_mutex_init-v7-2-d9e449f4d224@weissschuh.net
| -rw-r--r-- | drivers/leds/leds-lp8860.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c index 52b97c9f2a035..0962c00c215a1 100644 --- a/drivers/leds/leds-lp8860.c +++ b/drivers/leds/leds-lp8860.c @@ -307,7 +307,9 @@ static int lp8860_probe(struct i2c_client *client) led->client = client; led->led_dev.brightness_set_blocking = lp8860_brightness_set; - devm_mutex_init(&client->dev, &led->lock); + ret = devm_mutex_init(&client->dev, &led->lock); + if (ret) + return dev_err_probe(&client->dev, ret, "Failed to initialize lock\n"); led->regmap = devm_regmap_init_i2c(client, &lp8860_regmap_config); if (IS_ERR(led->regmap)) { |