diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-04-30 11:27:30 +0300 |
|---|---|---|
| committer | Hans Verkuil <hverkuil@xs4all.nl> | 2025-05-06 13:06:30 +0200 |
| commit | 3a9619be0dba738397b888a7674049321184a2f9 (patch) | |
| tree | 87566112ff17ae0f3217425f29da249a8e9f3a07 | |
| parent | a21e0a8941eaeb253fd64c516c4ea39bdf4db1c6 (diff) | |
media: i2c: imx334: uninitialized variable in imx334_update_exp_gain()
The "ret" variable is not initialized on the success path. Set it to
zero.
Fixes: 7b19b0fc8ac8 ("media: i2c: imx334: Convert to CCI register access helpers")
Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
| -rw-r--r-- | drivers/media/i2c/imx334.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c index fc875072f859..846b9928d4e8 100644 --- a/drivers/media/i2c/imx334.c +++ b/drivers/media/i2c/imx334.c @@ -536,7 +536,8 @@ static int imx334_update_controls(struct imx334 *imx334, static int imx334_update_exp_gain(struct imx334 *imx334, u32 exposure, u32 gain) { u32 lpfr, shutter; - int ret, ret_hold; + int ret_hold; + int ret = 0; lpfr = imx334->vblank + imx334->cur_mode->height; shutter = lpfr - exposure; |