diff options
| author | Vicki Pfau <vi@endrift.com> | 2025-02-04 19:55:29 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-02-21 14:01:15 +0100 |
| commit | 36fd8f1c735e73817f46781906c17f255aa28656 (patch) | |
| tree | 10f3ef9e69f4e6c1ff5ff0a6528d298dd3321353 | |
| parent | cdd9a1ea23ff1a272547217100663e8de4eada40 (diff) | |
HID: hid-steam: Don't use cancel_delayed_work_sync in IRQ context
[ Upstream commit b051ffa2aeb2a60e092387b6fb2af1ad42f51a3c ]
Lockdep reported that, as steam_do_deck_input_event is called from
steam_raw_event inside of an IRQ context, it can lead to issues if that IRQ
occurs while the work to be cancelled is running. By using cancel_delayed_work,
this issue can be avoided. The exact ordering of the work and the event
processing is not super important, so this is safe.
Fixes: cd438e57dd05 ("HID: hid-steam: Add gamepad-only mode switched to by holding options")
Signed-off-by: Vicki Pfau <vi@endrift.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/hid/hid-steam.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/hid-steam.c b/drivers/hid/hid-steam.c index bf8b633114be..9b6aec0733ae 100644 --- a/drivers/hid/hid-steam.c +++ b/drivers/hid/hid-steam.c @@ -1592,7 +1592,7 @@ static void steam_do_deck_input_event(struct steam_device *steam, if (!(b9 & BIT(6)) && steam->did_mode_switch) { steam->did_mode_switch = false; - cancel_delayed_work_sync(&steam->mode_switch); + cancel_delayed_work(&steam->mode_switch); } else if (!steam->client_opened && (b9 & BIT(6)) && !steam->did_mode_switch) { steam->did_mode_switch = true; schedule_delayed_work(&steam->mode_switch, 45 * HZ / 100); |