diff options
| author | Ulf Hansson <ulf.hansson@linaro.org> | 2025-04-02 14:06:13 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-06-27 11:11:27 +0100 |
| commit | 33cd650d38e494f4b3cdc2c751b16f3015ea59de (patch) | |
| tree | 8a2ca781d2d37c7a8ad00b43a9109cc564f1b9c6 | |
| parent | 02de16babe53c54a9aae1ba71f47ee70c2a6c939 (diff) | |
pmdomain: core: Reset genpd->states to avoid freeing invalid data
[ Upstream commit 99012014c902cd9ad85fd288d8a107f33a69855e ]
If genpd_alloc_data() allocates data for the default power-states for the
genpd, let's make sure to also reset the pointer in the error path. This
makes sure a genpd provider driver doesn't end up trying to free the data
again, but using an invalid pointer.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Dhruva Gole <d-gole@ti.com>
Link: https://lore.kernel.org/r/20250402120613.1116711-1-ulf.hansson@linaro.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/pmdomain/core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/pmdomain/core.c b/drivers/pmdomain/core.c index 8b1f894f5e79..2643525a572b 100644 --- a/drivers/pmdomain/core.c +++ b/drivers/pmdomain/core.c @@ -2228,8 +2228,10 @@ static int genpd_alloc_data(struct generic_pm_domain *genpd) return 0; put: put_device(&genpd->dev); - if (genpd->free_states == genpd_free_default_power_state) + if (genpd->free_states == genpd_free_default_power_state) { kfree(genpd->states); + genpd->states = NULL; + } free: if (genpd_is_cpu_domain(genpd)) free_cpumask_var(genpd->cpus); |