summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPavel Begunkov <asml.silence@gmail.com>2025-07-07 09:52:33 +0100
committerJens Axboe <axboe@kernel.dk>2025-07-07 06:53:54 -0600
commit203817de269539c062724d97dfa5af3cdf77a3ec (patch)
tree018d107fbcfabd5e524800835b6f19df124c215f
parent6f11adcc6f36ffd8f33dbdf5f5ce073368975bc3 (diff)
io_uring/zcrx: fix pp destruction warnings
With multiple page pools and in some other cases we can have allocated niovs on page pool destruction. Remove a misplaced warning checking that all niovs are returned to zcrx on io_pp_zc_destroy(). It was reported before but apparently got lost. Reported-by: Pedro Tammela <pctammela@mojatatu.com> Fixes: 34a3e60821ab9 ("io_uring/zcrx: implement zerocopy receive pp memory provider") Signed-off-by: Pavel Begunkov <asml.silence@gmail.com> Link: https://lore.kernel.org/r/b9e6d919d2964bc48ddbf8eb52fc9f5d118e9bc1.1751878185.git.asml.silence@gmail.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r--io_uring/zcrx.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c
index ade4da9c4e31..67c518d22e0c 100644
--- a/io_uring/zcrx.c
+++ b/io_uring/zcrx.c
@@ -862,10 +862,7 @@ static int io_pp_zc_init(struct page_pool *pp)
static void io_pp_zc_destroy(struct page_pool *pp)
{
struct io_zcrx_ifq *ifq = io_pp_to_ifq(pp);
- struct io_zcrx_area *area = ifq->area;
- if (WARN_ON_ONCE(area->free_count != area->nia.num_niovs))
- return;
percpu_ref_put(&ifq->ctx->refs);
}