diff options
| author | Ma Ke <make24@iscas.ac.cn> | 2025-02-02 14:23:57 +0800 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2025-03-10 13:41:48 -0500 |
| commit | 1f2768b6a3ee77a295106e3a5d68458064923ede (patch) | |
| tree | e8bee12a26f0fe80fc0afc54c6bdbca9b1e487c4 | |
| parent | 804443c1f27883926de94c849d91f5b7d7d696e9 (diff) | |
PCI: Fix reference leak in pci_alloc_child_bus()
If device_register(&child->dev) fails, call put_device() to explicitly
release child->dev, per the comment at device_register().
Found by code review.
Link: https://lore.kernel.org/r/20250202062357.872971-1-make24@iscas.ac.cn
Fixes: 4f535093cf8f ("PCI: Put pci_dev in device tree as early as possible")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Cc: stable@vger.kernel.org
| -rw-r--r-- | drivers/pci/probe.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index dc37a3c0a977..088131a74d7d 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -1222,7 +1222,10 @@ static struct pci_bus *pci_alloc_child_bus(struct pci_bus *parent, add_dev: pci_set_bus_msi_domain(child); ret = device_register(&child->dev); - WARN_ON(ret < 0); + if (WARN_ON(ret < 0)) { + put_device(&child->dev); + return NULL; + } pcibios_add_bus(child); |