libhurd-mm/

2007-11-22  Neal H. Walfield  <neal@gnu.org>

	* storage.h (struct storage): New struct.
	(storage_alloc): Return a struct storage, not an addr.  Update all
	callers.
	* storage.c (struct storage_desc): Remove field shadow.  Add field
	cap.
	(shadow_setup): Save the cap.
	(storage_alloc): Return a struct storage, not an addr.
	(storage_free): Correctly free the shadow if not used.  Update
	STORAGE->CAP to reflect that the folio has been removed.
	* capalloc.c (struct cappage_desc): Add field cap.
	(capalloc): Stash CAP.  When allocating a cappage, allocate a
	shadow object.
	(capfree): Really free CAPPAGE if there is another page available.
	If freeing CAPPAGE, unlink DESC and update DESC->CAP to reflect
	that the page has been deallocated, deallocate the shadow, and
	deallocate CAPPAGE.

	* exceptions.c (exception_thread): Print IP when a fault cannot be
	resolved.

	* mmap.c (mmap): Cast addr to a uintptr_t to elide warning.

ruth/

2007-11-22  Neal H. Walfield  <neal@gnu.org>

	* ruth.c (main): Update uses of stroage_alloc to its new
	interface.

1 files changed, 50 insertions, 10 deletions

diff --git a/libhurd-mm/capalloc.c b/libhurd-mm/capalloc.c
index c603dcf..85d86a1 100644
--- a/libhurd-mm/capalloc.c
+++ b/libhurd-mm/capalloc.c
@@ -38,6 +38,8 @@ struct cappage_desc
   hurd_btree_node_t node;
 
   addr_t cappage;
+  struct cap *cap;
+
   unsigned char alloced[CAPPAGE_SLOTS / 8];
   unsigned short free;
 
@@ -85,11 +87,12 @@ cappage_desc_slab_alloc (void *hook, size_t size, void **ptr)
 {
   assert (size == PAGESIZE);
 
-  addr_t storage = storage_alloc (meta_data_activity,
-				  cap_page, STORAGE_LONG_LIVED, ADDR_VOID);
-  if (ADDR_IS_VOID (storage))
+  struct storage storage = storage_alloc (meta_data_activity,
+					  cap_page, STORAGE_LONG_LIVED,
+					  ADDR_VOID);
+  if (ADDR_IS_VOID (storage.addr))
     panic ("Out of storage");
-  *ptr = ADDR_TO_PTR (addr_extend (storage, 0, PAGESIZE_LOG2));
+  *ptr = ADDR_TO_PTR (addr_extend (storage.addr, 0, PAGESIZE_LOG2));
 
   return 0;
 }
@@ -136,11 +139,36 @@ capalloc (void)
     {
       nonempty = cappage_desc_alloc ();
 
-      /* As there is such a large number of objects, we expect that
-	 the page will be long lived.  */
-      nonempty->cappage = storage_alloc (meta_data_activity,
-					 cap_cappage, STORAGE_LONG_LIVED,
-					 ADDR_VOID);
+      /* As there is such a large number of caps per cappage, we
+	 expect that the page will be long lived.  */
+      struct storage storage = storage_alloc (meta_data_activity,
+					      cap_cappage, STORAGE_LONG_LIVED,
+					      ADDR_VOID);
+      if (ADDR_IS_VOID (storage.addr))
+	{
+	  cappage_desc_free (nonempty);
+	  return ADDR_VOID;
+	}
+
+      nonempty->cappage = storage.addr;
+      nonempty->cap = storage.cap;
+
+      /* Then, allocate the shadow object.  */
+      struct storage shadow_storage
+	= storage_alloc (meta_data_activity, cap_page,
+			 STORAGE_LONG_LIVED, ADDR_VOID);
+      if (ADDR_IS_VOID (shadow_storage.addr))
+	{
+	  /* No memory.  */
+	  storage_free (nonempty->cappage, false);
+	  cappage_desc_free (nonempty);
+	  return ADDR_VOID;
+	}
+
+      struct object *shadow = ADDR_TO_PTR (addr_extend (shadow_storage.addr,
+							0, PAGESIZE_LOG2));
+      memset (shadow, 0, PAGESIZE);
+      cap_set_shadow (nonempty->cap, shadow);
 
       memset (&nonempty->alloced, 0, sizeof (nonempty->alloced));
       nonempty->free = CAPPAGE_SLOTS;
@@ -182,10 +210,22 @@ capfree (addr_t cap)
     /* No slots in the cappage are allocated.  Free it if there is at
        least one cappage on NONEMPTY.  */
     {
-      if (nonempty)
+      assert (nonempty);
+      if (nonempty->next)
 	{
 	  hurd_btree_cappage_desc_detach (&cappage_descs, desc);
+	  unlink (desc);
+
+	  struct object *shadow = cap_get_shadow (desc->cap);
+	  storage_free (addr_chop (PTR_TO_ADDR (shadow), PAGESIZE_LOG2),
+			false);
+	  cap_set_shadow (desc->cap, NULL);
+
+	  desc->cap->type = cap_void;
+
 	  cappage_desc_free (desc);
+
+	  storage_free (cappage, false);
 	}
     }
 }