summaryrefslogtreecommitdiff
path: root/kern/atomic.h
diff options
context:
space:
mode:
Diffstat (limited to 'kern/atomic.h')
-rw-r--r--kern/atomic.h80
1 files changed, 44 insertions, 36 deletions
diff --git a/kern/atomic.h b/kern/atomic.h
index 1f0430e3..67f775db 100644
--- a/kern/atomic.h
+++ b/kern/atomic.h
@@ -13,18 +13,22 @@
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ *
+ * Type-generic memory-model aware atomic operations.
*/
#ifndef _KERN_ATOMIC_H
#define _KERN_ATOMIC_H
+#include <stdbool.h>
+
#include <kern/macros.h>
#include <machine/atomic.h>
/*
* Supported memory orders.
*/
-
#define ATOMIC_RELAXED __ATOMIC_RELAXED
#define ATOMIC_ACQUIRE __ATOMIC_ACQUIRE
#define ATOMIC_RELEASE __ATOMIC_RELEASE
@@ -34,85 +38,89 @@
/*
* Type-generic atomic operations.
*/
+#define atomic_fetch_add(ptr, val, mo) __atomic_fetch_add(ptr, val, mo)
-#define atomic_fetch_add(ptr, val, mo) __atomic_fetch_add((ptr), (val), mo)
+#define atomic_fetch_sub(ptr, val, mo) __atomic_fetch_sub(ptr, val, mo)
-#define atomic_fetch_sub(ptr, val, mo) __atomic_fetch_sub((ptr), (val), mo)
+#define atomic_fetch_and(ptr, val, mo) __atomic_fetch_and(ptr, val, mo)
-#define atomic_fetch_and(ptr, val, mo) __atomic_fetch_and((ptr), (val), mo)
+#define atomic_fetch_or(ptr, val, mo) __atomic_fetch_or(ptr, val, mo)
-#define atomic_fetch_or(ptr, val, mo) __atomic_fetch_or((ptr), (val), mo)
+#define atomic_fetch_xor(ptr, val, mo) __atomic_fetch_xor(ptr, val, mo)
-#define atomic_fetch_xor(ptr, val, mo) __atomic_fetch_xor((ptr), (val), mo)
+#define atomic_add(ptr, val, mo) (void)__atomic_add_fetch(ptr, val, mo)
-#define atomic_add(ptr, val, mo) ((void)__atomic_add_fetch((ptr), (val), mo))
+#define atomic_sub(ptr, val, mo) (void)__atomic_sub_fetch(ptr, val, mo)
-#define atomic_sub(ptr, val, mo) ((void)__atomic_sub_fetch((ptr), (val), mo))
+#define atomic_and(ptr, val, mo) (void)__atomic_and_fetch(ptr, val, mo)
-#define atomic_and(ptr, val, mo) ((void)__atomic_and_fetch((ptr), (val), mo))
+#define atomic_or(ptr, val, mo) (void)__atomic_or_fetch(ptr, val, mo)
-#define atomic_or(ptr, val, mo) ((void)__atomic_or_fetch((ptr), (val), mo))
+#define atomic_xor(ptr, val, mo) (void)__atomic_xor_fetch(ptr, val, mo)
-#define atomic_xor(ptr, val, mo) ((void)__atomic_xor_fetch((ptr), (val), mo))
-
-#define atomic_swap(ptr, val, mo) __atomic_exchange_n((ptr), (val), mo)
+#define atomic_swap(ptr, val, mo) __atomic_exchange_n(ptr, val, mo)
/*
- * For compare-and-swap, we deviate a little from the standard, and only
+ * For compare-and-swap, deviate a little from the standard, and only
* return the value before the comparison, leaving it up to the user to
* determine whether the swap was actually performed or not.
+ *
* Also, note that the memory order in case of failure is relaxed. This is
* because atomic CAS is typically used in a loop. However, if a different
* code path is taken on failure (rather than retrying), then the user
* should be aware that a memory fence might be necessary.
+ *
+ * Finally, although a local variable isn't strictly needed for the new
+ * value, some compilers seem to have trouble when all parameters don't
+ * have the same type.
*/
-
-#define atomic_cas(ptr, exp, nval, mo) \
+#define atomic_cas(ptr, oval, nval, mo) \
MACRO_BEGIN \
- typeof(*(ptr)) ___exp, ___nval; \
+ typeof(*(ptr)) ___oval, ___nval; \
\
- ___exp = (exp); \
+ ___oval = (oval); \
___nval = (nval); \
- __atomic_compare_exchange_n((ptr), &___exp, ___nval, 0, mo, \
- ATOMIC_RELAXED); \
- ___exp; \
+ __atomic_compare_exchange_n(ptr, &___oval, ___nval, false, \
+ mo, ATOMIC_RELAXED); \
+ ___oval; \
MACRO_END
/*
* Some architectures may need specific definitions for loads and stores,
* in order to prevent the compiler from emitting unsupported instructions.
- * As such, we only define these if the arch header didn't already.
+ * As such, only define these if the architecture-specific part of the
+ * module didn't already.
*/
-#ifndef ATOMIC_LOAD_DEFINED
-#define atomic_load(ptr, mo) __atomic_load_n((ptr), mo)
-#endif /* ATOMIC_LOAD_DEFINED */
+#ifndef ATOMIC_ARCH_SPECIFIC_LOAD
+#define atomic_load(ptr, mo) __atomic_load_n(ptr, mo)
+#endif
-#ifndef ATOMIC_STORE_DEFINED
-#define atomic_store(ptr, val, mo) __atomic_store_n((ptr), (val), mo)
-#endif /* ATOMIC_STORE_DEFINED */
+#ifndef ATOMIC_ARCH_SPECIFIC_STORE
+#define atomic_store(ptr, val, mo) __atomic_store_n(ptr, val, mo)
+#endif
/*
* Common shortcuts.
*/
-#define atomic_cas_acquire(ptr, exp, val) \
- atomic_cas(ptr, exp, val, ATOMIC_ACQUIRE)
+#define atomic_cas_acquire(ptr, oval, nval) \
+ atomic_cas(ptr, oval, nval, ATOMIC_ACQUIRE)
-#define atomic_cas_release(ptr, exp, val) \
- atomic_cas(ptr, exp, val, ATOMIC_RELEASE)
+#define atomic_cas_release(ptr, oval, nval) \
+ atomic_cas(ptr, oval, nval, ATOMIC_RELEASE)
-#define atomic_cas_seq_cst(ptr, exp, val) \
- atomic_cas(ptr, exp, val, ATOMIC_SEQ_CST)
+#define atomic_cas_seq_cst(ptr, oval, nval) \
+ atomic_cas(ptr, oval, nval, ATOMIC_SEQ_CST)
#define atomic_swap_acquire(ptr, val) atomic_swap(ptr, val, ATOMIC_ACQUIRE)
#define atomic_swap_release(ptr, val) atomic_swap(ptr, val, ATOMIC_RELEASE)
#define atomic_swap_seq_cst(ptr, val) atomic_swap(ptr, val, ATOMIC_SEQ_CST)
-#define atomic_fetch_add_acq_rel(ptr, val) \
+#define atomic_fetch_add_acq_rel(ptr, val) \
atomic_fetch_add(ptr, val, ATOMIC_ACQ_REL)
-#define atomic_fetch_sub_acq_rel(ptr, val) \
+#define atomic_fetch_sub_acq_rel(ptr, val) \
atomic_fetch_sub(ptr, val, ATOMIC_ACQ_REL)
#define atomic_or_acq_rel(ptr, val) atomic_or(ptr, val, ATOMIC_ACQ_REL)