summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-09-29staging: rtl8821ae: remove driverGreg Kroah-Hartman
There is now a "real" driver in the wireless tree for this hardware device, so remove the staging driver as it is no longer needed. Reported-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-29staging: et131x: Simplify for loop in et131x_init_send()Mark Einon
The for loop in this function increments two variables and has an unusual starting index of 1 (not 0). Make it look more familiar. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Mark Einon <mark.einon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-29staging: et131x: Audit and update commentsMark Einon
Many of the functions and variables in the driver have been renamed and are now more understandable, as well as defines added for various constants. Update / remove some comments to reflect this. Also many comments were unnecessary dialogue describing what is evident from the code, or comments were just plain incorrect. Remove these too. Signed-off-by: Mark Einon <mark.einon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: rtl8192u: ieee80211: Converted symbol to static.Aybuke Ozdemir
This patch fixes this sparse warning: drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c:60:6: warning: symbol 'ieee80211_ccmp_aes_encrypt' was not declared. Should it be static? Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: rtl8192u: Add blank line after variable declarationsGeorgiana Chelu
Fix the following checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: Georgiana Chelu <georgiana.chelu93@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28Staging: rtl8192e: Remove unused variableMahati Chamarthy
This patch removes a variable which has never been used. The following Coccinelle semantic patch was used to make this transformation: @@ type T; identifier i; constant C; @@ - T i; <... when != i - i = C; ...> Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: rtl8192u: Fixed trailing whitespace in copyingEsra Altintas
The following patch fixes the checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Esra Altintas <es.altintas@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: rtl8192u: remove space before close parenthesis ")"Roxana Blaj
This fixes the checkpatch.pl error: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: rtl8192u: remove space before semicolonRoxana Blaj
This fixes the checkpatch.pl warning: WARNING: space prohibited before semicolon Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: rtl8192u: add space after close brace '}'Roxana Blaj
This fixes the checkpatch.pl error: ERROR: space required after that close brace '}' Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com> Acked-by: Daniel Baluta <daniel.baluta@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: slicoss: Fix void function return statements style warningDilek Uzulmez
This fixes "void function return statements are not generally useful" checkpatch.pl warning slicoss.c Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: rtl8192u: add space before the open parenthesis '('Roxana Blaj
This fixes the checkpatch.pl error: ERROR: space required before the open parenthesis '(' Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28Staging: rtl8192e: rtl8192e: Remove assigned unused variableMahati Chamarthy
This patch removes an initialized variable which has never been used. The following Coccinelle semantic patch was used to make this transformation: @e@ identifier i; position p; type T; @@ extern T i@p; @@ type T; identifier i; constant C; position p != e.p; @@ - T i@p; <+... when != i - i = C; ...+> The braces around if and else which become unnecessary after the transformation were also removed. Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: octeon: Fix missing blank line warning.Melike Yurtoglu
Fixes "Missing a blank line after declarations" checkpatch.pl warning in ethernet-rgmii.c Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: octeon: Removed unnecessary else expression.Dilek Uzulmez
This patch fixes "else is not generally useful after a break or return" checkpatch.pl warning ethernet-util.h Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com> Acked-by: Daniel Baluta <daniel.baluta@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: octeon: Fix line 80 characters in ethernet.cEsra Altintas
The following patch fixes the checpatch.pl warning: WARNING: line over 80 characters Signed-off-by: Esra Altintas <es.altintas@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28drivers: staging: gdm72xx: Removed unnecessary braces.Gulsah Kose
This patch fixes "braces {} are not necessary for single statement blocks" checkpatch.pl warning in netlink_k.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28drivers: staging: gdm72xx: Removed unnecessary else expression.Gulsah Kose
This patch fixes "else is not generally useful after a break or return" checkpatch.pl warning in netlink_k.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: gdm724x: Removed unnecessary else expression.Gulsah Kose
This patch fixes "else is not generally useful after a break or return" checkpatch.pl warning in gdm_usb.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: ft1000: ft1000-pcmcia: Add require space after that ','Aybuke Ozdemir
This patch fixes checkpatch.pl error in file ft1000_hw.c ERROR: space required after that ';' (ctx:VxV) Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: ft1000: ft1000-pcmcia: Used "linux" instead of "asm".Gulsah Kose
This patch fixes "Use #include <linux/uaccess.h> instead of <asm/uaccess.h" checkpatch.pl warning in ft1000_dnld.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: ft1000: ft1000-pcmcia: Removed unnecessary else expression.Gulsah Kose
This patch fixes "else is not generally useful after a break or return" checkpatch.pl warning in ft1000_dnld.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28Staging: unisys: common-spar: include: channels: Remove unnecessary semicolonAybuke Ozdemir
This fixes the checkpatch.pl warning: WARNING: macros should not use a trailing semicolon. Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: vt6655: Merge three lines into oneTapasweni Pathak
This patch merges three lines into one, removing unecessary if check. Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com> Reviewed-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: vt6656: Merge three lines into oneTapasweni Pathak
This patch merges three lines into one, removing if branch Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: vt6655: Type conversion was made.Gulsah Kose
This patch fixes this sparse warning: drivers/staging/vt6655/device_main.c:385:40: warning: mixing different enum types drivers/staging/vt6655/device_main.c:385:40: int enum _VIA_BB_TYPE versus drivers/staging/vt6655/device_main.c:385:40: int enum _VIA_PKT_TYPE Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28Staging: vt6655: Add require space before that '('Aybuke Ozdemir
This patch fixes checkpatch.pl error in file device_main.c ERROR: space required before the open parenthesis '(' Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28Staging: vt6655: Add require space after that ','Aybuke Ozdemir
This patch fixes checkpatch.pl error in file device_main.c ERROR: space required after that ';' (ctx:VxV) Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: speakup: Added blank line.Aybuke Ozdemir
This patch fixes "Missing a blank line after declarations" checkpatch.pl warning in selection.c Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28Staging: speakup: Fix trailing spaceAybuke Ozdemir
This patch fixes checkpatch.pl error in file spkguide.txt ERROR: trailing whitespace Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28Staging: wlan-ng: Fix unnecessary space before function pointer argumentsAybuke Ozdemir
This patch fixes these warning messages found by checkpatch.pl: WARNING: Unnecessary space before function pointer arguments Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: rtl8723au: core: Add space after '|'Aybuke Ozdemir
This patch fixes checkpatch.pl error in file rtw_ap.c ERROR: need consistent spacing around '|' (ctx:WxV) Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: rtl8723au: core: Add consistent spacing around '&'Aybuke Ozdemir
This patch fixes checkpatch.pl error in file rtw_ap.c ERROR: need consistent spacing around '&' (ctx:WxV) Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: rtl8723au: hal: Removed unnecessary braces.Aybuke Ozdemir
This patch fixes "braces {} are not necessary for single statement blocks" checkpatch.pl warning in hal_com.c Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: rtl8723au: hal: Fix missing blank line warning.Aybuke Ozdemir
This patch fixes "Missing a blank line after declarations" checkpatch.pl warning in hal_com.c Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: rtl8723au: hal: Fix unnecessary whitespace before a quoted newlineAybuke Ozdemir
Fix checkpatch.pl issues with unnecessary whitespace before a quoted newline in hal_com.c Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: emxx_udc: Fixed else is not usefull warning.Gulsah Kose
This patch fixes "else is not generally useful after a break or return" checkpatch.pl warning in emxx_udc.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: ft1000-usb: use usleep_range instead of msleepCatalina Mocanu
This fixes the following checkpatch.pl warning: WARNING : msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt Signed-off-by: Catalina Mocanu <catalina.mocanu@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: ft1000-usb: remove unnecessary return statementCatalina Mocanu
This fixes the following checkpatch.pl warning: WARNING: void function return statements are not generally useful Signed-off-by: Catalina Mocanu <catalina.mocanu@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: media: omap4iss: Removed unnecessary else expression.Gulsah Kose
This patch fixes "else is not generally useful after a break or return" checkpatch.pl warning iss_resizer.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: media: omap4iss: Removed unnecessary else expression.Gulsah Kose
This patch fixes "else is not generally useful after a break or return" checkpatch.pl warning iss_ipipeif.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: media: omap24xx: Added blank line.Gulsah Kose
This patch fixes "Missing a blank line after declarations" checkpatch.pl warning in tcm825x.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: media: omap24xx: Added new line after declarations.Gulsah Kose
This patch fixes "Missing a blank line after declarations" checkpatch.pl warning in omap24xxcam-dma.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: media: cxd2099: use usleep_range()Tapasweni Pathak
This patch fixes checkpatch.pl warning in file cxd2099.c WARNING : msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28Staging: media: davinci_vpfe: Remove unused variableMahati Chamarthy
This patch removes a variable which has never been used. The following Coccinelle semantic patch was used to make this transformation: @@ type T; identifier i; constant C; @@ - T i; <... when != i - i = C; ...> Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28Staging: media: davinci_vpfe: Removed unnecessary out of memory message logging.Heena Sirwani
The following patch removes the checkpatch.pl warning: WARNING: possible unnecessary out of memory message. Signed-off-by: Heena Sirwani <heenasirwani@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: media: lirc: Removed unnecessary else expression.Gulsah Kose
This patch fixes "else is not generally useful after a break or return" checkpatch.pl warning lirc_parallel.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28Staging: media: lirc: Add new line after declarationsTapasweni Pathak
This patch fixes checkpatch.pl warning in files of media/lirc WARNING : Missing a blank line after declarations Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28Staging: dgnc: Remove space before parenthesisMahati Chamarthy
This fixes the following checkpatch.pl error: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Mahati Chamarthy <mahati.chamarthy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28staging: dgnc: dgnc_driver.h: Remove non-standard spinlock's macrosRoberta Dobrescu
This patch removes non-standard spinlock's macros as they are no longer used by this driver. Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>